Repository navigation
Depend on the released Datalayer packages - #61
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Version floors only: @datalayer/primer-addons 1.0.23, @datalayer/core 1.2.12, @datalayer/agent-runtimes 1.3.13, @datalayer/jupyter-react, jupyter-lexical, jupyter-embed and jupyter-docusaurus-plugin 2.0.17; no code change.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical packaging and build issues, compatibility problems, and breaking package changes remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (3)
What changed in this PR
This PR raises Datalayer dependency floors but also expands the icon catalog, changes packaging/build configuration, and removes the Vue package.
Changes:
- Adds and updates numerous
data1anddata2SVG icons. - Publishes the root React icon package and updates TypeScript, scripts, dependencies, and documentation.
- Removes Vue package files and obsolete assets.
- Unresolved issues remain in package loading, published imports, build cleanup, SVG validity, React peer compatibility, and package scope.
| File | Description |
|---|---|
vue/package.json |
Removes Vue package metadata; breaking package removal remains unresolved. |
vue/index.js |
Removes the Vue CommonJS entrypoint. |
vue/index.esm.js |
Removes the Vue ESM entrypoint. |
vue/.gitignore |
Removes Vue ignore rules. |
tsconfig.node.json |
Updates Node-side compiler settings. |
tsconfig.json |
Switches module resolution to Bundler. |
svg/data2/toolbox.svg |
Adds toolbox icon. |
svg/data2/signal.svg |
Adds signal icon. |
svg/data2/ring.svg |
Adds ring icon. |
svg/data2/radioactive.svg |
Adds radioactive icon. |
svg/data2/placard.svg |
Adds placard icon. |
svg/data2/page-facing-up.svg |
Adds page icon. |
svg/data2/megaphone.svg |
Adds megaphone icon. |
svg/data2/loudspeaker.svg |
Adds loudspeaker icon. |
svg/data2/lighthouse-alexandria.svg |
Adds lighthouse icon. |
svg/data2/light-bubble.svg |
Adds light-bubble icon. |
svg/data2/ledger.svg |
Adds ledger icon. |
svg/data2/hotel.svg |
Adds hotel icon. |
svg/data2/graduation-cap.svg |
Adds graduation-cap icon. |
svg/data2/floppy-disk.svg |
Adds floppy-disk icon. |
svg/data2/disk-optical.svg |
Adds optical-disk icon. |
svg/data2/disk-computer.svg |
Adds computer-disk icon. |
svg/data2/diamond.svg |
Adds diamond icon. |
svg/data2/diamond-dot.svg |
Adds dotted-diamond icon. |
svg/data2/desktop-computer.svg |
Adds desktop icon. |
svg/data2/department-store.svg |
Adds department-store icon. |
svg/data2/crystal-ball.svg |
Adds crystal-ball icon. |
svg/data2/christmas-tree.svg |
Adds Christmas-tree icon. |
svg/data2/castle.svg |
Adds castle icon. |
svg/data2/camera.svg |
Adds camera icon. |
svg/data2/camera-video.svg |
Adds video-camera icon. |
svg/data2/camera-movie.svg |
Adds movie-camera icon. |
svg/data2/camera-flash.svg |
Adds camera-flash icon. |
svg/data2/bookmark-tabs.svg |
Adds bookmark-tabs icon. |
svg/data2/book-orange.svg |
Adds orange-book icon. |
svg/data2/book-notes.svg |
Adds notes-book icon. |
svg/data2/book-notes-decorative.svg |
Adds decorative notes-book icon. |
svg/data2/book-green.svg |
Adds green-book icon. |
svg/data2/book-closed.svg |
Adds closed-book icon. |
svg/data2/book-blue.svg |
Adds blue-book icon. |
svg/data2/archive.svg |
Adds archive icon. |
svg/data1/web-rtc.svg |
Adds WebRTC icon. |
svg/data1/vue-js.svg |
Adds Vue.js icon. |
svg/data1/view.svg |
Makes the view icon theme-aware. |
svg/data1/users.svg |
Adds users icon. |
svg/data1/user.svg |
Adds user icon. |
svg/data1/tiktok.svg |
Makes TikTok icon theme-aware. |
svg/data1/tensor-flow.svg |
Adds TensorFlow icon. |
svg/data1/temporal.svg |
Adds Temporal icon. |
svg/data1/student2.svg |
Adds student icon. |
svg/data1/shuffle.svg |
Adds shuffle icon. |
svg/data1/redo.svg |
Makes redo icon theme-aware. |
svg/data1/radar.svg |
Adds radar icon; missing viewBox blocks generation. |
svg/data1/pydantic.svg |
Makes Pydantic icon theme-aware. |
svg/data1/open-teams-bw.svg |
Removes Open Teams variant. |
svg/data1/null-6.svg |
Makes icon theme-aware. |
svg/data1/null-4.svg |
Makes icon theme-aware. |
svg/data1/null-3.svg |
Makes icon theme-aware. |
svg/data1/null-2.svg |
Makes icon theme-aware. |
svg/data1/network.svg |
Makes network icon theme-aware. |
svg/data1/modal.svg |
Adds Modal icon. |
svg/data1/key-outline.svg |
Adds key-outline icon. |
svg/data1/kerberos.svg |
Makes Kerberos icon theme-aware. |
svg/data1/kaggle.svg |
Adds Kaggle icon. |
svg/data1/editor.svg |
Adds editor icon. |
svg/data1/edit.svg |
Makes edit icon theme-aware. |
svg/data1/e2b.svg |
Adds E2B icon. |
svg/data1/e2b-3.svg |
Adds E2B wordmark icon. |
svg/data1/drag-indicator.svg |
Makes drag indicator theme-aware. |
svg/data1/docusaurus.svg |
Adds Docusaurus icon. |
svg/data1/docker.svg |
Adds Docker icon. |
svg/data1/docker-name.svg |
Adds Docker wordmark. |
svg/data1/daytona.svg |
Adds Daytona icon. |
svg/data1/dataset.svg |
Adds dataset icon. |
svg/data1/database.svg |
Adds database icon; class name needs correction. |
svg/data1/cloud-white.svg |
Adds cloud icon. |
svg/data1/cloud-virtual-machine.svg |
Adds cloud VM icon. |
svg/data1/camera2.svg |
Adds alternate camera icon. |
svg/data1/camera.svg |
Removes camera asset. |
svg/data1/browser.svg |
Makes browser icon theme-aware. |
svg/data1/azure.svg |
Updates Azure styling; theme color inheritance needs restoration. |
svg/data1/azure-bw.svg |
Removes Azure monochrome variant. |
svg/data1/atproto.svg |
Adds AT Protocol icon. |
svg/data1/apple-rainbow.svg |
Adds Apple Rainbow icon. |
svg/data1/angular.svg |
Adds Angular icon. |
svg/data1/alibaba-cloud.svg |
Adds Alibaba Cloud icon. |
svg/data1/a2a.svg |
Makes A2A icon theme-aware. |
src/index.ts |
Exports DatalayerIcons; published relative import is unresolved. |
README.md |
Updates the icon build command. |
package.json |
Adds root publishing, scripts, and dependencies; package loading and compatibility issues remain. |
Makefile |
Adds root-package publishing support. |
icons-react/package.json |
Updates the React package version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+4
| "version": "0.0.1", | ||
| "private": false, |
Comment on lines
1
to
5
| import * as icons from "../icons-react"; | ||
|
|
||
| export { DatalayerIcons } from "./DatalayerIcons"; | ||
|
|
||
| export default icons; |
Comment on lines
+40
to
+41
| "react": "19.2.8", | ||
| "react-dom": "19.2.8", |
…datalayer scope comes from npmjs - release.yaml replaces publish-dev.yml: a v* tag (icons-react's version) builds the icons and publishes @datalayer/icons-react -- and @datalayer/icons-all whenever its version is not on npm -- through the npm environment (OIDC trusted publishing, with provenance). No more dev prereleases to GitHub Packages on every push to main. RELEASE.md. - buid.yml -> build.yaml, on Node 22. - .yarnrc.yml: the @datalayer scope is on npmjs, so the GitHub Packages route -- and the token it carried, which had expired and made every install fail with 'Invalid authentication' -- is gone. - @datalayer/icons-react 1.0.14 -> 1.0.15.
…solves) and no polymorphic Heading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the minimum versions to the packages just released: npm
@datalayer/primer-addons1.0.23,@datalayer/core1.2.12,@datalayer/agent-runtimes1.3.13,@datalayer/jupyter-react/jupyter-lexical/jupyter-embed/jupyter-docusaurus-plugin2.0.17. Version floors only; no code change — together with what this branch already carries.