ci: adopt shared build checks and guarded updates - #35
Merged
Merged
Conversation
![darkestdarky-bot[bot]](https://avatars.githubusercontent.com/in/3783368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR adopts shared, pinned CI workflows and replaces the test script's write-side format step with a read-only check, matching the stated intent. No credentials, injection, data‑loss, or accessibility issues are visible in the diff. The changes are tightly scoped and follow repository conventions. No blocking or P1 defects observed.
Review coverage: 89/89 diff lines supplied. Inline comments are limited to fully visible, valid right-side hunks. Reviewed commit: ca3fdf07392a9892b43f7ad2876a9ff4e067a6bc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test now builds the application with the shared components and the repository's Bun and Node pins, then runs read-only checks. The check generates React Router types before linting; a clean build alone does not produce the route types, which caused five missing-import errors in hosted CI. The writable format command remains available separately.
Dependabot merging uses the shared current-head/latest-run guard after Test succeeds, restricted to stable patch/minor GitHub Actions updates. Application dependencies, major, 0.x, prerelease and unrecognized updates remain manual. Lighthouse now warns and records an explicit skipped audit when its optional Vercel token, team or project cannot be resolved. All downstream audit and comment steps skip; transport, malformed-response and actual audit failures retain their failure behavior.
Validation: the clean sequence frozen install → production build → check passed under Bun 1.3.5 and Node 24.20.0 without previously generated route types. Explicit typecheck also passed; lint had zero errors/warnings and formatting passed 205 files. Hosted Test now passes. Independent review, shared workflow contract checks and frozen hashes passed. Lighthouse passed 18 shell fixtures here (54 across the three updated repositories), plus syntax and configured-path parity checks. Hosted discovery confirmed the warning and downstream skips.
No test suite exists. The Lighthouse skip produced no audit scores or report comments; a configured audit and comment delivery remain unverified. This PR adds no required branch checks or workflow-enablement settings. The merge workflow's hosted execution and a natural Dependabot cycle remain acceptance steps.