feat: support monero_wallet URI restoration - #1261
Conversation
Co-Authored-By: detherminal <76167420+detherminal@users.noreply.github.com>
these shouldn't exist/happen, but do/can
previously if it had a newline at the beginning it would choke
monero_wallet worked. now monero-wallet works, too there's a frustrating variety of xmr wallet uri schemes: some with underscores, some with dashes
|
Conflicts in minor and resolvable ways with #1278 ... converting to a draft for now but this can be merged first |
|
will this allow you to import a monero account from the keys? |
Yes and no: yes it will allow importing via keys (in the form of a URI, anyways), but no it does not allow 12 word BIP39 seeds to be imported, which is separate functionality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1261 +/- ##
===========================================
+ Coverage 4.79% 6.03% +1.23%
===========================================
Files 1109 1113 +4
Lines 111003 111487 +484
===========================================
+ Hits 5325 6727 +1402
+ Misses 105678 104760 -918 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
supports seed, view_key only, and spend_key and view_key.