flash: Optimize away redundant file reads - #269
Merged
Merged
Conversation
Because it comes up in our target workload (which opens the same GFA from multiple odgi commands), this attempts to optimize redundant reads of the same file to only do a single read. This probably doesn't matter at all for `map-file` which is presumably very fast, but it feels nice and could potentially actually matter in other situations. In a little experiment, I am surprised to see that this might have actually saved a *little* bit of time: * before: 395.4 ms ± 2.4 ms * after: 387.1 ms ± 2.6 ms I didn't expect anything at all, so even a tiny delta is worth celebrating, I guess. This is a very restricted CSE optimization. We could generalize it much further if we run into cases where it would be helpful...
Just trying to isolate the effects of all the optimizations we have now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because it comes up in our target workload (which opens the same GFA from multiple odgi commands), this attempts to optimize redundant reads of the same file to only do a single read. This doesn't matter much
map-filewhich is presumably very fast, but it feels nice and could potentially actually matter in other situations.In a little experiment, I am surprised to see that this might have actually saved a little bit of time:
I didn't expect anything at all, so even a tiny delta is worth celebrating, I guess. 🎉
This is essentially a very restricted CSE optimization. We could generalize it much further if we run into cases where it would be helpful...