flash: Further optimize depth computations - #268
Merged
Merged
Conversation
When computing interval depths, we're not interested in the unique depth. So this provides an alternate code path that does not compute that part. In an experiment on my M1 Max MBP, this took the end-to-end script running time from 1.32s to 0.716s.
For our current target workload, we use `odgi depth -r` to compute the length of a path. But, by default, that uselessly performs a depth computation. This adds a separate `path-length` instruction that *just* does the length calculation instead. Instead of exposing that explicitly, we have an optimization that tries to detect when this instruction suffices and swaps it in. In a quick experiment here, this optimization makes the full workload go from 724ms to 404ms, or about a 1.8x speedup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two new optimizations:
Altogether, these optimizations are worth a speedup of about 3.2×.
Checking in on all our options for doing this one weird computation:
So on the bottom line, we are now about 38× faster than odgi.