Skip to content

Implement close action with v2 hooks using a finalizer #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy-clerc merged 2 commits into from
Mar 4, 2026
Merged

Implement close action with v2 hooks using a finalizer #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
662d354
Implement close action with v2 hooks using a finalizer
jeremy-clerc Mar 3, 2026
581410d
update finalizer name to be namespace as ndc
jeremy-clerc Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions api/v1alpha1/nodedisruption_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,10 @@ type NodeDisruptionStatus struct {
type DisruptedBudgetStatus struct {
Reference NamespacedName `json:"reference,omitempty"`
Reason string `json:"reason"`
Preparing bool `json:"preparing"`
Ok bool `json:"ok"`
// Preparing is set to true when the application manager started preparation. Value is kept true even when the app is ready.
Preparing bool `json:"preparing"`

@damsallem damsallem Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if instead of having a boolean, an enum value with 3 state : Preparing / Ready / Closing wouldn't be more suitable.
Ok was legacy, so keeping it for retro-compatibility seems the right thing to do.

// Ok is set to true when application manager preparation is complete and ready for the NodeDisruption to continue.
Ok bool `json:"ok"`
}

//+kubebuilder:object:root=true
Expand Down
6 changes: 3 additions & 3 deletions app_manager_openapi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ paths:
$ref: '#/responses/RetryAfter'
default:
$ref: '#/responses/UnexpectedError'
/cancel:
/close:
post:
summary: Cancel application preparation for a disruption.
operationId: cancelPreparation
summary: Notify the end of a disruption if the application needs to unprepare.
operationId: closeDisruption
tags:
- disruption
consumes:
Expand Down
153 changes: 0 additions & 153 deletions internal/appmgrcli/disruption/cancel_preparation_parameters.go
View file
Open in desktop

This file was deleted.

172 changes: 0 additions & 172 deletions internal/appmgrcli/disruption/cancel_preparation_responses.go
View file
Open in desktop

This file was deleted.

Loading
Loading