Fix #14113 (Slow analysis: microchip xc16 code)#7838
Draft
glankk wants to merge 1 commit into
Draft
Conversation
|
|
423cb76 to
646c05b
Compare
cb700d2 to
6d8d7b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Improves check times for sources with many conditionally includes files by implementing lazy loading of headers. Lazy loading is only implemented for single-config checks because cppcheck currently needs to open all possibly included headers in order to discover configs automatically. Lazy loading for automatic configurations is possible by discovering new configurations as files are loaded, and it's something I think should be implemented in the future. I've done preliminary tests showing that it significantly speeds up check times when using
-f, but there are some complications that need to be figured out and it's outside the scope of this PR.Some changes have been made to
Preprocessor; since preprocessing has to be done per-file as they are included, many functions have been changed or overloaded to act on a specific file instead of all previously loaded files. Some dumps have been changed to be completed after checking is done, when the full list of included files is known.A test has been added to
test/cli/performance_test.py.Benchmarks
Test file:
Before:
After: