Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions cot-cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ quote.workspace = true
syn.workspace = true
tracing.workspace = true
tracing-subscriber = { workspace = true, features = ["env-filter"] }
serde = { workspace = true, features = ["derive"] }
serde_json = {workspace = true}
Comment thread
ElijahAhianyo marked this conversation as resolved.

[dev-dependencies]
cot-cli = { path = ".", features = ["test_utils"] }
Expand Down
85 changes: 85 additions & 0 deletions cot-cli/src/args.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,15 @@
use std::ffi::OsString;
use std::path::PathBuf;

use clap::{Args, Parser, Subcommand};
use clap_verbosity_flag::Verbosity;

pub const PACKAGE_LONG_FLAG: &str = "--package";
pub const PACKAGE_SHORT_FLAG: &str = "-p";
pub const RELEASE_FLAG: &str = "--release";
pub const HELP_LONG_FLAG: &str = "--help";
pub const HELP_SHORT_FLAG: &str = "-h";

#[derive(Debug, Parser)]
#[command(
name = "cot",
Expand All @@ -11,6 +18,13 @@ use clap_verbosity_flag::Verbosity;
long_about = None
)]
pub struct Cli {
/// Use target/release instead of target/debug when looking for the project
/// binary
#[arg(long, global = true)]
release: bool,
/// Package to use, in case you're running this in a workspace
#[arg(short = 'p', long, global = true, value_name = "PACKAGE")]
pub package: Option<String>,
#[command(flatten)]
pub verbose: Verbosity,
#[command(subcommand)]
Expand All @@ -29,6 +43,9 @@ pub enum Commands {
/// Manage Cot CLI
#[command(subcommand)]
Cli(CliCommands),

#[command(external_subcommand)]
External(Vec<OsString>),
}

#[derive(Debug, Args)]
Expand Down Expand Up @@ -119,3 +136,71 @@ pub struct CompletionsArgs {
/// Shell to generate completions for
pub shell: clap_complete::Shell,
}

/// Pulls `-p <name>` / `--package <name>` / `--package=<name>` out of raw
/// argv, before clap has parsed anything. Needed because `project::load`
/// must run before `Cli::parse()` for the `--help` interception path.
#[must_use]
pub fn extract_package_arg(raw: &[String]) -> Option<String> {
let mut iter = raw.iter();
while let Some(arg) = iter.next() {
if let Some(value) = arg.strip_prefix(&format!("{PACKAGE_LONG_FLAG}=")) {
return Some(value.to_string());
}
if arg == PACKAGE_LONG_FLAG || arg == PACKAGE_SHORT_FLAG {
return iter.next().cloned();
}
}
None
}

#[cfg(test)]
mod tests {
use super::*;

fn args(raw: &[&str]) -> Vec<String> {
raw.iter().map(|arg| (*arg).to_string()).collect()
}

#[test]
fn extract_package_arg_long_with_separate_value() {
let raw = args(&["cot", "--release", "--package", "blog", "check"]);

assert_eq!(extract_package_arg(&raw), Some("blog".to_string()));
}

#[test]
fn extract_package_arg_long_with_equals_value() {
let raw = args(&["cot", "--package=blog", "check"]);

assert_eq!(extract_package_arg(&raw), Some("blog".to_string()));
}

#[test]
fn extract_package_arg_short_with_value() {
let raw = args(&["cot", "-p", "blog", "check"]);

assert_eq!(extract_package_arg(&raw), Some("blog".to_string()));
}

#[test]
fn extract_package_arg_returns_first_package_flag() {
let raw = args(&["cot", "-p", "first", "--package", "second", "check"]);

assert_eq!(extract_package_arg(&raw), Some("first".to_string()));
}

#[test]
fn extract_package_arg_missing_value_returns_none() {
let raw = args(&["cot", "check", "-p"]);

assert_eq!(extract_package_arg(&raw), None);
}

#[test]
fn extract_package_arg_absent_returns_none() {
let raw = args(&["cot", "--release", "check"]);

assert_eq!(extract_package_arg(&raw), None);
}
}
Loading
Loading