Skip to content

Update vga.js #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copy merged 2 commits into from
Aug 31, 2026
+5 −3
Merged

Update vga.js #1622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b65581
Update vga.js
Godlance Aug 21, 2026
1c1e676
simplify fix
copy Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/vga.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2533,13 +2533,15 @@ VGAScreen.prototype.screen_fill_buffer = function()
if(this.svga_bpp === 8)
{
// XXX: Slow, should be ported to rust, but it doesn't have access to vga256_palette
// XXX: Doesn't take svga_offset into account
const buffer = new Int32Array(this.cpu.wasm_memory.buffer, this.dest_buffet_offset, this.screen_width * this.screen_height);
const svga_memory = new Uint8Array(this.cpu.wasm_memory.buffer, this.svga_memory.byteOffset, this.vga_memory_size);
// svga_offset selects the visible part of svga_memory, used for page flipping (e.g. Master of Orion 2)
const base = this.svga_offset;
const end = Math.min(buffer.length, this.vga_memory_size - base);

for(var i = 0; i < buffer.length; i++)
for(var i = 0; i < end; i++)
{
var color = this.vga256_palette[svga_memory[i]];
var color = this.vga256_palette[svga_memory[base + i]];
buffer[i] = color & 0xFF00 | color << 16 | color >> 16 | 0xFF000000;
}
}
Expand Down