fix: treat SSE comment lines as comments, not end-of-stream - #13144
Open
tonycoder-hub wants to merge 1 commit into
Open
fix: treat SSE comment lines as comments, not end-of-stream#13144tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
A `: ping` keepalive was reported as `done`, which broke out of the line loop in streamSse and left the rest of the chunk unparsed. When the ping arrived in the same chunk as later data events, the leftover buffer was parsed as a single line and the stream failed with "Malformed JSON sent from server".
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This was referenced Aug 17, 2026
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
cursor
Bot
force-pushed
the
cursor/fix-sse-ping-comment-handling-9a9e
branch
from
August 17, 2026 10:44
0ebe433 to
cc47459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseSseLine treated a : ping keepalive as done, so later data events in the same chunk were left in the buffer and JSON.parse failed (Malformed JSON sent from server). SSE comments should be ignored. Distinct from #12976 and #12604. packages/fetch test: 98 passed.