fix: only treat tar as create when the mode flag is actually c - #13143
Open
tonycoder-hub wants to merge 1 commit into
Open
fix: only treat tar as create when the mode flag is actually c#13143tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
…chive creation `isSafeCommand` scanned every tar argument for a "c", so file operands such as `archive.tar.gz` made extraction look like archive creation. `tar -xzf archive.tar.gz` was therefore auto-approved without a permission prompt. Restrict the create-flag check to tar's mode flags (short bundles with or without a leading dash, and `--create`). Co-authored-by: Tony Coder <407243179@qq.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This was referenced Aug 17, 2026
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
cursor
Bot
force-pushed
the
cursor/fix-tar-create-flag-detection-88a8
branch
from
August 17, 2026 10:44
e510f18 to
d2bb4ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe-create check matched any argument containing the letter c. Mode flags only. 228 tests passed in packages/terminal-security.