Restore the e2e test bodies removed in #441 - #491
Merged
Conversation
ling-senpeng13
marked this pull request as ready for review
August 13, 2026 23:31
manan164
approved these changes
Aug 14, 2026
manan164
left a comment
manan164
left a comment
Contributor
There was a problem hiding this comment.
Please fix the flaky test
#441 deleted four test functions along with the cli_credentials conftest fixture, leaving suites 2 and 3 collecting nothing and suites 4 and 5 unable to run. Restored verbatim, with one substantive change: credentials now go through the server's /api/secrets REST API instead of shelling out to the agentspan CLI. The CLI targeted /api/credentials, which only Orkes serves (404 on conductor-oss) — that was the sole reason these suites could not run there. They now run on both, and need no conftest fixture. suite collected Orkes conductor-oss 2 tool_calling 0 -> 1 pass skip (store read-only) 3 cli_tools 0 -> 1 pass skip at the credential write 4 mcp_tools 1 -> 2 pass pass 5 http_tools 1 -> 2 pass pass Suites 4 and 5 adopt a pre-provisioned credential when the store is read-only, so their authenticated phases run on conductor-oss too. Suites 2 and 3 set and then update values, which requires a writable store, so they skip there with a message naming the cause. Also: suite 3's whitelist checks moved ahead of the credential write (they need no store, and were otherwise stranded behind the skip), and suite 4 gains an assertion that a tool result the model cannot invent appears in the answer. test_suite16_cli_skills.py was also removed by #441 — intentionally, so not restored.
ling-senpeng13
force-pushed
the
fix/restore-e2e-tests-removed-in-441
branch
from
August 14, 2026 16:17
d9a3d26 to
50045a9
Compare
conductor-oss serves secrets from the server process environment and rejects writes, so a suite that consumes a credential can only get one if it is set at boot. CI started the server bare, so suites 4 and 5 self-skipped their authenticated phases even though the behaviour they cover works there. Verified against the same configuration CI uses — bare 3.32.0-rc18, fresh DB, only these two variables set: 4 passed, 0 skipped (previously both suites skipped). Suites 2 and 3 still skip, and cannot be fixed this way: suite 2 sets and then updates a credential, and suite 3 removes one before adding it back, so both need a mutable store rather than a pre-provisioned value. Suite 3 additionally needs a real GITHUB_TOKEN.
Contributor
Author
Rebase the mainline and rerun the test to fix the integration tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#441 deleted four test functions along with the
cli_credentialsconftest fixture, leaving suites 2 and 3 collecting nothing and suites 4 and 5 unable to run.Restored verbatim, with one substantive change: credentials now go through the server's
/api/secretsREST API instead of shelling out to theagentspanCLI.Suites 4 and 5 adopt a pre-provisioned credential when the store is read-only, so their authenticated phases run on conductor-oss too. Suites 2 and 3 set and then update values, which requires a writable store, so they skip there with a message naming the cause.
Also: suite 3's whitelist checks moved ahead of the credential write (they need no store, and were otherwise stranded behind the skip), and suite 4 gains an assertion that a tool result the model cannot invent appears in the answer.
test_suite16_cli_skills.pywas also removed by #441 — intentionally, so not restored.