Fix sub_results iteration in the skills examples - #476
Merged
Conversation
ling-senpeng13
marked this pull request as ready for review
August 12, 2026 23:05
ling-senpeng13
force-pushed
the
fix/skills-examples-sub-results
branch
from
August 14, 2026 17:52
11920d0 to
243e5c2
Compare
kowser-orkes
approved these changes
Aug 14, 2026
sub_results is a dict keyed by agent name, so iterating it yields strings. 32_skills_multi_agent.py parallel died on the print — PARALLEL is the strategy that actually populates it: AttributeError: 'str' object has no attribute 'status' The other two call sites have the same bug and survived only because their sub_results was empty. Iterate .items() and print the agent name with its output. Verified against a 3.32.0-rc18 server: all 8 modes across both examples now complete, and parallel prints all three sub-agent outputs.
ling-senpeng13
force-pushed
the
fix/skills-examples-sub-results
branch
from
August 14, 2026 21:13
548226b to
ed4132d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sub_resultsis a dict keyed by agent name rather than object list, so iterating it yields strings.32_skills_multi_agent.py paralleldied on the print — PARALLEL is the strategy that actually populates it:src/conductor/ai/agents/result.py#L124
The other two call sites have the same bug, and survived only because their
sub_resultswas empty.Verified against a 3.32.0-rc18 server: all 8 modes across both examples complete, and
parallelprints all three sub-agent outputs.