Stabilize device online status - #709
Open
rahulsiiitm wants to merge 1 commit into
Open
Conversation
|
Welcome to connect! Make sure to:
deployed preview: https://709.connect-d5y.pages.dev |
rahulsiiitm
marked this pull request as ready for review
August 7, 2026 07:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop auxiliary Athena RPCs from overwriting device presence.
Device API refreshes already provide the authoritative
last_athena_ping. Network-status and upload RPCs were also setting it to either the current time or zero, so out-of-order responses could make a reachable device flicker online and offline.Keep the upload and network-state updates unchanged, but remove their presence writes.
fetchDeviceOnline()remains the sole action-level writer and continues to useDevices.fetchDevice().Also fix the network probe's expected-error condition: timeout and unregistered-device errors are ignored, while unexpected errors are still reported.
Tested:
oxlint srcThe existing live geocoding integration test depends on an external service and timed out locally.
Fixes #687