Repository navigation
Conversation
Check CRLF pairing before resetting previousSlashN/R so Windows newlines do not double-count lines and truncate output early. Fixes com-lihaoyi#165
arimu1
force-pushed
the
fix/truncated-crlf-line-count-165
branch
from
September 12, 2026 13:06
e1001a5 to
aa76bbc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Truncated.handleNormalCharso\r\nand\n\rcount as a single line break by checking the CRLF pair before resettingpreviousSlashN/previousSlashR."Hello\r\nWorld"at width 80 yields two lines (not three).Fixes #165
Test plan
./mill 'pprint.jvm[2.13.15].test'(includesAdvancedTests.truncatedAttrsCRLF case)