Repository navigation
Restore compatibility with Python < 3.8 - #745
Merged
Merged
Conversation
The `dirs_exist_ok` argument was added in Python 3.8. This should be an empty temporary directory each time the tests run so we don't actually need to pre-create the directory, meaning we don't actually need this argument at all.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 75 75
Lines 4686 4686
Branches 816 816
=======================================
Hits 4088 4088
Misses 468 468
Partials 130 130 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christophebedard
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dirs_exist_okargument was added in Python 3.8. This should be an empty temporary directory each time the tests run so we don't actually need to pre-create the directory, meaning we don't actually need this argument at all.