Repository navigation
chore: change default_org_member_roles to set - #438
Conversation
Duplicate role names make no sense
| "requires the `minimum-implicit-member` experiment to be enabled on the Coder Deployment.", | ||
| "Changes propagate to members on their next request.", | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
Ideally this resource should have a validator:
Validators: []validator.Set{
setvalidator.ValueStringsAre(
stringvalidator.OneOf("owner", "template-admin", "user-admin", "auditor"),
),
},
and ideally we should import that list of strings from codersdk so it's not so brittle
There was a problem hiding this comment.
In saying that, we dont currently have an import for it on coderd_user.roles, which is where I copied that snippet from
There was a problem hiding this comment.
I actually don't think the session token from the provider block is available to us in the validator, so custom role validation is maybe impossible
We don't support custom roles here yet. So I can copy the list as it stands today.
We don't add roles very often, but the list is only static to a given version of coderd.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9de379a2ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Followup to #355 (comment).
Change
default_org_member_rolesoncoderd_organizationfrom a list to a set.minimum-implicit-memberexperiment note in the attribute description with "Requires a Coder Deployment running v2.37.0 or later." The experiment was promoted to GA and removed in feat: promote MinimumImplicitMember experiment to GA coder#27472, first shipped in v2.37.0.minimum-implicit-memberfrom the acceptance test'sCoderExperiments(...)list, since Coder v2.37.0+ no longer recognises it.Coder Agents on behalf of @Emyrk.