Repository navigation
fix(copilot): remove hardcoded model enum to allow any Copilot model - #833
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes hardcoded copilot_model enum validation in the Copilot module so users can specify any GitHub Copilot-supported model string without being blocked by outdated allowlists.
Changes:
- Removed the
copilot_modelvariable enum validation and updated its description to allow any Copilot-supported model. - Updated Terraform tests to confirm arbitrary model strings are accepted and still produce the expected environment variable behavior.
- Bumped README example module version pins to
0.4.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
registry/coder-labs/modules/copilot/main.tf |
Removes strict model allowlist validation and updates variable description. |
registry/coder-labs/modules/copilot/copilot.tftest.hcl |
Replaces allowlist-based test coverage with a custom-model acceptance plan test. |
registry/coder-labs/modules/copilot/README.md |
Updates module version pins in examples to 0.4.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
copilot_modelvariable was restricted to a hardcoded enum of three models (claude-sonnet-4,claude-sonnet-4.5,gpt-5). Models change fast and this validation was blocking users from using newer models.Changes
validationblock fromcopilot_modelvariable inmain.tf0.4.1in README examplesCloses #832