Skip to content

chore: add placeholder to git config inputs - #694

Merged
Emyrk merged 4 commits into
mainfrom
stevenmasley/git_config_flair
Feb 4, 2026
Merged

Emyrk merged 4 commits into
mainfrom
stevenmasley/git_config_flair

Conversation

@Emyrk

@Emyrk Emyrk commented Feb 3, 2026 •

Copy link
Copy Markdown
Member

Description

Shows the user the value that will be used if no value is inserted

Example: https://playground.coder.app/parameters/iS3csy5Th7

Screenshot From 2026-02-03 11-44-00

Type of Change

  • Feature/enhancement

Module Information

Path: registry/coder/modules/git-config
Breaking change: [ ] Yes [x] No

Shows the user the value that will be used if no value is inserted
@Emyrk
Emyrk requested a review from matifali February 3, 2026 17:44
@matifali matifali added the version:patch Add to PRs requiring a patch version upgrade label Feb 3, 2026
@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Version Bump Required

One or more modules in this PR need their versions updated.

To fix this:

  1. Run the version bump script locally:
    ./.github/scripts/version-bump.sh patch
  2. Commit the changes:
    git add . && git commit -m "chore: bump module versions (patch)"
  3. Push your changes

The CI will automatically re-run once you push the updated versions.

@matifali matifali left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good UX addition. Thanks.

Please bump a patch version.

@Emyrk

Emyrk commented Feb 3, 2026

Copy link
Copy Markdown
Member Author

Bumped!

@matifali matifali removed the version:patch Add to PRs requiring a patch version upgrade label Feb 4, 2026
@matifali

matifali commented Feb 4, 2026 •

Copy link
Copy Markdown
Member

@Emyrk could you run bun fmt Thanks. There is a CI failure.

@Emyrk

Emyrk commented Feb 4, 2026

Copy link
Copy Markdown
Member Author

@Emyrk could you run bun fmt Thanks. There is a CI failure.

@matifali I will get everything right in one of these commits! 😄

@matifali matifali added the version:minor Add to PRs requiring a minor version upgrade label Feb 4, 2026
@coder coder deleted a comment from github-actions Bot Feb 4, 2026
@matifali matifali added version:patch Add to PRs requiring a patch version upgrade and removed version:minor Add to PRs requiring a minor version upgrade labels Feb 4, 2026
@Emyrk
Emyrk merged commit 6ac4d70 into main Feb 4, 2026
5 of 6 checks passed
@Emyrk
Emyrk deleted the stevenmasley/git_config_flair branch February 4, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch Add to PRs requiring a patch version upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants