Repository navigation
fix(jfrog): replace deprecated --repo-resolve flag for Maven - #535
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the JFrog CLI Maven configuration to replace the deprecated --repo-resolve flag with the newer --repo-resolve-releases and --repo-resolve-snapshots flags in both the jfrog-oauth and jfrog-token modules.
- Replaces deprecated
--repo-resolveflag with separate flags for releases and snapshots - Updates Maven configuration to use the same repository for both releases and snapshots
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| registry/coder/modules/jfrog-token/run.sh | Updates Maven configuration command to use --repo-resolve-releases and --repo-resolve-snapshots flags |
| registry/coder/modules/jfrog-oauth/run.sh | Updates Maven configuration command to use --repo-resolve-releases and --repo-resolve-snapshots flags |
DevelopmentCats
left a comment
DevelopmentCats
left a comment
There was a problem hiding this comment.
the only issue I see with this is there is no way to configure these repo's independently. This would make it work in the mean-time, but it might be good to change this to allow someone to provide seperate repo url's for release, and snapshot artifacts.
DevelopmentCats
left a comment
DevelopmentCats
left a comment
There was a problem hiding this comment.
If we don't care about the above because it essentially retains the previous functionality we are good but we need to bump the versions
|
this should be good now I have tested it as well |
DevelopmentCats
changed the title
…nfig Replace deprecated --repo-resolve with --repo-resolve-releases and --repo-resolve-snapshots for jf mvn-config command. Verified with JFrog CLI v2.82.0.
…nfig Same fix as jfrog-oauth - replace --repo-resolve with --repo-resolve-releases and --repo-resolve-snapshots.
Update test expectations to check for separate --repo-resolve-releases and --repo-resolve-snapshots flags instead of deprecated --repo-resolve.
…erver ID and repository flags
1e5b0d5 to
e5f07fd
Compare
DevelopmentCats
changed the title
bjornrobertsson
left a comment
bjornrobertsson
left a comment
There was a problem hiding this comment.
Code looks good, I see the --repo* and --server-id* are extended over the minimum needed (i.e. from the proposed addition needed by end-user)
Fixes deprecated Maven config flags in jfrog-oauth and jfrog-token modules
closes #534
Done using GitHub Copilot.