Skip to content

chore: privatize pal and platforms - #19225

Merged
star-e merged 4 commits into
cocos:v3.8.9from
qiuguohua:v3.8.9_platforms_pal
Sep 18, 2026
Merged

star-e merged 4 commits into
cocos:v3.8.9from
qiuguohua:v3.8.9_platforms_pal

Conversation

@qiuguohua

Copy link
Copy Markdown
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Too many files changed for review (368 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

@qiuguohua
qiuguohua requested a review from star-e September 14, 2026 06:02
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Code Size Check Report

Wechat (WASM) Before After Diff
2D Empty (legacy pipeline) 1009972 bytes 1010166 bytes ⚠️ +194 bytes
2D All (legacy pipeline) 2676439 bytes 2676639 bytes ⚠️ +200 bytes
2D All (new pipeline) 2768175 bytes 2768377 bytes ⚠️ +202 bytes
(2D + 3D) All 10025363 bytes 10025563 bytes ⚠️ +200 bytes
Web (WASM + ASMJS) Before After Diff
(2D + 3D) All 16845507 bytes 16845565 bytes ⚠️ +58 bytes

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -66054,8 +66054,9 @@
         export enum _pal_system_info_enum_type_platform__Platform {
             UNKNOWN = "UNKNOWN",
             EDITOR_PAGE = "EDITOR_PAGE",
             EDITOR_CORE = "EDITOR_CORE",
+            NODEJS_PAGE = "NODEJS_PAGE",
             MOBILE_BROWSER = "MOBILE_BROWSER",
             DESKTOP_BROWSER = "DESKTOP_BROWSER",
             WIN32 = "WIN32",
             ANDROID = "ANDROID",

@qiuguohua

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

@qiuguohua, Please check the result of run test cases:

Task Details

@github-actions

Copy link
Copy Markdown

@qiuguohua, Please check the result of run test cases:

Task Details

@star-e
star-e merged commit 597a926 into cocos:v3.8.9 Sep 18, 2026
14 checks passed
@qiuguohua

Copy link
Copy Markdown
Contributor Author

@cocos-robot run test cases

@github-actions

Copy link
Copy Markdown

@qiuguohua, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL graphics-continuous-filling
ios PASS PASS PASS
mac PASS PASS PASS

@github-actions

Copy link
Copy Markdown

@qiuguohua, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants