Repository navigation
fix(mesh): fix custom attribute stride and 32-bit index in createMesh - #19224
Merged
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
Contributor
Author
|
@cocos-robot run test cases |
Contributor
Author
|
@cocos-robot run-test-cases-custom |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
@MagicXHouse, Please check the result of
Task Details |
|
@MagicXHouse, Please check the result of
Task Details |
|
@MagicXHouse, Please check the result of
Task Details |
|
@MagicXHouse, Please check the result of
Task Details |
|
@MagicXHouse, Please check the result of
Task Details |
|
@MagicXHouse, Please check the result of
Task Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
previous attribute's format when computing vertex stride, fixing
misaligned vertex data on native platforms.
meshes with more than 65535 vertices instead of silently truncating.
Continuous Integration
This pull request:
Compatibility Check
This pull request: