Release cortex v0.3.4 - #1093
Merged
Merged
Conversation
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Adoption](https://docs.renovatebot.com/merge-confidence/) | [Passing](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---|---|---| | [k8s.io/api](https://redirect.github.com/kubernetes/api) | `v0.36.2` → `v0.36.3` |  |  |  |  | | [k8s.io/apimachinery](https://redirect.github.com/kubernetes/apimachinery) | `v0.36.2` → `v0.36.3` |  |  |  |  | | [k8s.io/client-go](https://redirect.github.com/kubernetes/client-go) | `v0.36.2` → `v0.36.3` |  |  |  |  | --- ### Release Notes <details> <summary>kubernetes/api (k8s.io/api)</summary> ### [`v0.36.3`](https://redirect.github.com/kubernetes/api/compare/v0.36.2...v0.36.3) [Compare Source](https://redirect.github.com/kubernetes/api/compare/v0.36.2...v0.36.3) </details> <details> <summary>kubernetes/apimachinery (k8s.io/apimachinery)</summary> ### [`v0.36.3`](https://redirect.github.com/kubernetes/apimachinery/compare/v0.36.2...v0.36.3) [Compare Source](https://redirect.github.com/kubernetes/apimachinery/compare/v0.36.2...v0.36.3) </details> <details> <summary>kubernetes/client-go (k8s.io/client-go)</summary> ### [`v0.36.3`](https://redirect.github.com/kubernetes/client-go/compare/v0.36.2...v0.36.3) [Compare Source](https://redirect.github.com/kubernetes/client-go/compare/v0.36.2...v0.36.3) </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Berlin) - Branch creation - "after 6pm every weekday,every weekend,before 8am every weekday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cobaltcore-dev/cortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNzUuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI3NS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/sapcc/go-bits](https://redirect.github.com/sapcc/go-bits) | require | digest | `acf388e` → `89c8670` | --- ### Configuration 📅 **Schedule**: (in timezone Europe/Berlin) - Branch creation - "after 6pm every weekday,every weekend,before 8am every weekday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cobaltcore-dev/cortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNzUuMiIsInVwZGF0ZWRJblZlciI6IjQzLjI3NS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The year is not needed to denote that SAP has copyright on cortex. Signed-off-by: Philipp Matthes <p.matthes@sap.com>
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Adoption](https://docs.renovatebot.com/merge-confidence/) | [Passing](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://redirect.github.com/prometheus/client_golang) | `v1.24.0` → `v1.24.1` |  |  |  |  | require | patch | | [kube-prometheus-stack](https://redirect.github.com/prometheus-operator/kube-prometheus) ([source](https://redirect.github.com/prometheus-community/helm-charts)) | `87.19.0` → `87.19.2` |  |  |  |  | | patch | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.24.1`](https://redirect.github.com/prometheus/client_golang/compare/v1.24.0...v1.24.1) [Compare Source](https://redirect.github.com/prometheus/client_golang/compare/v1.24.0...v1.24.1) </details> <details> <summary>prometheus-community/helm-charts (kube-prometheus-stack)</summary> ### [`v87.19.2`](https://redirect.github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-87.19.2) [Compare Source](https://redirect.github.com/prometheus-community/helm-charts/compare/kube-prometheus-stack-87.19.1...kube-prometheus-stack-87.19.2) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[CI] Update docker/login-action action to v4.5.1 by [@​renovate](https://redirect.github.com/renovate)\[bot] in [#​7134](https://redirect.github.com/prometheus-community/helm-charts/pull/7134) - \[CI] Update dependency helm-unittest/helm-unittest to v1.1.2 by [@​renovate](https://redirect.github.com/renovate)\[bot] in [#​7135](https://redirect.github.com/prometheus-community/helm-charts/pull/7135) - \[kube-prometheus-stack] Update Helm release grafana to v12.8.1 by [@​renovate](https://redirect.github.com/renovate)\[bot] in [#​7136](https://redirect.github.com/prometheus-community/helm-charts/pull/7136) **Full Changelog**: <prometheus-community/helm-charts@kube-prometheus-stack-87.19.1...kube-prometheus-stack-87.19.2> ### [`v87.19.1`](https://redirect.github.com/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-87.19.1) kube-prometheus-stack collects Kubernetes manifests, Grafana dashboards, and Prometheus rules combined with documentation and scripts to provide easy to operate end-to-end Kubernetes cluster monitoring with Prometheus using the Prometheus Operator. #### What's Changed - \[kube-prometheus-stack] Update kube-prometheus-stack dependency non-major updates by [@​renovate](https://redirect.github.com/renovate)\[bot] in [#​7132](https://redirect.github.com/prometheus-community/helm-charts/pull/7132) **Full Changelog**: <prometheus-community/helm-charts@prometheus-operator-admission-webhook-0.42.3...kube-prometheus-stack-87.19.1> </details> --- ### Configuration 📅 **Schedule**: (in timezone Europe/Berlin) - Branch creation - "after 6pm every weekday,every weekend,before 8am every weekday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/cobaltcore-dev/cortex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI4MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
setAccepted unconditionally wrote a new AcceptedAt timestamp and a time-varying StatusSummary on every call, causing a non-empty status patch even when the CR was already accepted for the current generation. The self-watch (EnqueueRequestForObject) fired on each patch, re-enqueuing every accepted cores commitment in a tight ~2s loop and keeping the workqueue depth permanently elevated around 80. Add an early-return guard in setAccepted that skips the patch when Ready=True/Accepted is already set for the current generation. --------- Signed-off-by: Julius Clausnitzer <julius.clausnitzer@sap.com>
## Summary - Add `### History` section to `docs/apis.md` documenting the History CRD as a scheduling decision audit trail, with relationship to pipelines noted and added to the mermaid diagram - Add link to `docs/guides/multicluster/readme.md` from the documentation landing page ## Test plan - [ ] Verify markdown renders correctly - [ ] Confirm History CRD documentation matches actual struct in `api/v1alpha1/history_types.go` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Assisted-by: Claude Code:claude-opus-4-8 [Bash] [Read] [Edit] Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
…es (#1092) ## Summary - Add `Reset()` calls on `numberOfReservations` and `reservedResources` GaugeVecs before repopulating in `Collect`, preventing stale label combinations from persisting when reservations are deleted or change status - Add context timeout on the Kubernetes List call to prevent scrape hangs - Follows the same pattern already used in `internal/scheduling/reservations/capacity/metrics.go` ## Test plan - [ ] Verify `make test` passes - [ ] Verify `make lint` passes - [ ] Compare with the capacity/metrics.go pattern to confirm consistency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Assisted-by: Claude Code:claude-opus-4-8 [Bash] [Read] [Edit] Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
The capacity filter assigned hypervisor Status.Capacity map references directly into a local working map, then mutated those maps during free-resource calculations. Since the maps are shared with the controller-runtime informer cache, each scheduling pass permanently decremented cached capacity values, progressively starving scheduling until all hosts appeared full. Fix: deep-copy the capacity map per hypervisor before subtracting allocations so the informer cache is never mutated. Assisted-by: Claude Code:claude-opus-4-8 [Bash] [Read] [Edit] Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
bump app version [skip ci] ``` bumped cortex: sha-38f37225 -> sha-4f44f3b7 bumped cortex-shim: sha-38f37225 -> sha-51c773d9 noop cortex-postgres (sha-e06153f8) ``` Signed-off-by: juliusclausnitzer <65490082+juliusclausnitzer@users.noreply.github.com> Co-authored-by: juliusclausnitzer <65490082+juliusclausnitzer@users.noreply.github.com>
juliusclausnitzer
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
mblos and
umswmayj
as code owners
July 27, 2026 12:24
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@claude run the /release 1093 command |
Contributor
|
Claude finished @juliusclausnitzer's task in 9m 46s —— View job Release Orchestrator Complete ✅
SummaryCreated release prep PR #1094 with changelog and version bumps for cortex v0.3.4. 9 commits since v0.3.3, including 3 bug fixes:
Plus documentation updates and dependency bumps. Merge order:
|
Merged
3 tasks
## Summary - Adds changelog entry for cortex v0.3.4 - Bumps helm chart versions across all bundles and library charts - Release prep for #1093: merge this before merging #1093 ## Test plan - [ ] Verify changelog entry is correct and complete - [ ] Verify helm chart version bumps are consistent across all charts - [ ] CI passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: juliusclausnitzer <juliusclausnitzer@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Test Coverage ReportTest Coverage 📊: 70.3% |
Collaborator
Author
|
@claude i merged the prep PR, finish title and fix description |
Contributor
|
Claude finished @juliusclausnitzer's task in 56s —— View job Finishing Release PR #1093
Done! Updated the PR:
|
bump app version [skip ci] ``` bumped cortex: sha-4f44f3b7 -> sha-68212b99 noop cortex-shim (sha-51c773d9) noop cortex-postgres (sha-e06153f8) ``` Signed-off-by: juliusclausnitzer <65490082+juliusclausnitzer@users.noreply.github.com> Co-authored-by: juliusclausnitzer <65490082+juliusclausnitzer@users.noreply.github.com>
umswmayj
approved these changes
Jul 27, 2026
Varsius
approved these changes
Jul 27, 2026
PhilippMatthes
approved these changes
Jul 27, 2026
SoWieMarkus
approved these changes
Jul 27, 2026
juliusclausnitzer
added a commit
that referenced
this pull request
Jul 28, 2026
## Summary - Adds changelog entry for cortex v0.3.4 - Bumps helm chart versions across all bundles and library charts - Release prep for #1093: merge this before merging #1093 ## Test plan - [ ] Verify changelog entry is correct and complete - [ ] Verify helm chart version bumps are consistent across all charts - [ ] CI passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: cortex-ai-agents[bot] <279748396+cortex-ai-agents[bot]@users.noreply.github.com> Co-authored-by: juliusclausnitzer <juliusclausnitzer@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release cortex v0.3.4
Release prep PR: #1094 ✅
Changes since v0.3.3
Bug Fixes
Reset()calls onnumberOfReservationsandreservedResourcesGaugeVecs before repopulating inCollect, preventing stale label combinations from persisting when reservations are deleted or change status (fix: reset gauge metrics in reservation monitor to prevent stale values #1092)setAcceptedunconditionally wrote a new AcceptedAt timestamp and a time-varying StatusSummary on every call, causing a non-empty status patch even when the CR was already accepted. Adds an early-return guard that skips the patch when Ready=True/Accepted is already set for the current generation (fix: stop committed resource controller reconcile storm #1089)Non-breaking Changes
github.com/prometheus/client_golangto v1.24.1 (Renovate: Update External dependencies #1090)k8s.io/api,k8s.io/apimachinery,k8s.io/client-goto v0.36.3 (Renovate: Update External dependencies to v0.36.3 #1086)github.com/sapcc/go-bits(Renovate: Update github.com/sapcc/go-bits digest to 89c8670 #1085)kube-prometheus-stackto 87.19.2 (Renovate: Update External dependencies #1090)Version Bumps