Skip to content

Exclude server output from saas-admin static assets - #1183

Merged
kale-stew merged 2 commits into
mainfrom
kylie/fix/saas-admin-assetsignore
Nov 3, 2026
Merged

kale-stew merged 2 commits into
mainfrom
kylie/fix/saas-admin-assetsignore

Conversation

@kale-stew

@kale-stew kale-stew commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Description

saas-admin-template/public/.assetsignore is empty, so wrangler deploy uploads the Astro server build (dist/_worker.js/) and the dist/index.js wrapper as static assets along with the client files. This PR lists them in .assetsignore, plus _routes.json, _headers, and _redirects, matching astro-blog-starter-template.

Validation

Ran npm ci, npm run build, npm run wrangler:wrapper, then wrangler dev --local:

Path Empty .assetsignore (main) This PR
/ 200 200
/favicon.svg 200 200
/_worker.js/index.js 200 500 (handled by the Worker, same as any unknown path)
/index.js 200 500 (handled by the Worker, same as any unknown path)
/_routes.json 200 500 (handled by the Worker, same as any unknown path)

#1166 makes the same change as part of its source map work. This PR lands it separately.

Checklist

This PR changes one ignore file in an existing template, so the template checklist doesn't apply.

The template's public/.assetsignore was empty, so the Astro server build
under dist/_worker.js and the dist/index.js wrapper were uploaded as static
assets alongside the client files. List them, matching
astro-blog-starter-template.
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Dashboard preview link

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Dashboard preview link

@kale-stew
kale-stew merged commit dc4e76b into main Nov 3, 2026
3 checks passed
@kale-stew
kale-stew deleted the kylie/fix/saas-admin-assetsignore branch November 3, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants