Repository navigation
Exclude server output from saas-admin static assets - #1183
Merged
Merged
Conversation
The template's public/.assetsignore was empty, so the Astro server build under dist/_worker.js and the dist/index.js wrapper were uploaded as static assets alongside the client files. List them, matching astro-blog-starter-template.
7 tasks
Contributor
rozenmd
approved these changes
Nov 3, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
saas-admin-template/public/.assetsignoreis empty, sowrangler deployuploads the Astro server build (dist/_worker.js/) and thedist/index.jswrapper as static assets along with the client files. This PR lists them in.assetsignore, plus_routes.json,_headers, and_redirects, matchingastro-blog-starter-template.Validation
Ran
npm ci,npm run build,npm run wrangler:wrapper, thenwrangler dev --local:.assetsignore(main)//favicon.svg/_worker.js/index.js/index.js/_routes.json#1166 makes the same change as part of its source map work. This PR lands it separately.
Checklist
This PR changes one ignore file in an existing template, so the template checklist doesn't apply.