fix: avoid panics by removing unwraps during HttpPeer DNS resolution#920
Open
rxdiscovery wants to merge 1 commit into
Open
fix: avoid panics by removing unwraps during HttpPeer DNS resolution#920rxdiscovery wants to merge 1 commit into
rxdiscovery wants to merge 1 commit into
Conversation
rxdiscovery
changed the title
rxdiscovery
force-pushed
the
fix-dns-unwrap
branch
from
13b37d8 to
b055895
Compare
rxdiscovery
changed the title
drcaramelsyrup
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: make peer/health_check safe, update proxy trait, and hide server headers
unwrap()calls inHttpPeerandHttpHealthCheckinitializers. Theirnew()andnew_mtls()functions now returnResult<Self>instead ofSelf.Closes #921