Skip to content

fix: update nix dependency to 0.30 for FreeBSD compatibility#707

Open
seuros wants to merge 1 commit into
cloudflare:mainfrom
seuros:fix/freebsd-nix-dependency
Open

fix: update nix dependency to 0.30 for FreeBSD compatibility#707
seuros wants to merge 1 commit into
cloudflare:mainfrom
seuros:fix/freebsd-nix-dependency

Conversation

@seuros

@seuros seuros commented Oct 5, 2025

Copy link
Copy Markdown

Problem

The current nix dependency (~0.24.3) causes compilation failures on FreeBSD due to kevent struct mismatches:

error[E0308]: mismatched types
   --> nix-0.24.3/src/sys/event.rs:227:19
    |
227 |            data: data as type_of_data,
    |                   ^^^^^^^^^^^^^^^^^^^^ expected `i64`, found `isize`

error[E0063]: missing field `ext` in initializer of `kevent`

Solution

Update nix dependency from ~0.24.3 to 0.30, which includes FreeBSD compatibility fixes.

Testing

  • Compiles successfully on FreeBSD 14.x
  • Compiles successfully on FreeBSD 15.x
  • All existing tests pass (pending CI) (1 failing test seem unrelated to upgrade)

Impact

This change only affects Unix builds and updates a compatible version of the nix crate. No API changes.

@seuros seuros marked this pull request as draft October 5, 2025 19:55
@seuros seuros marked this pull request as ready for review October 5, 2025 20:11
@seuros seuros marked this pull request as draft October 5, 2025 20:14
@seuros seuros force-pushed the fix/freebsd-nix-dependency branch 3 times, most recently from db4d42b to f163389 Compare October 5, 2025 20:33
@seuros seuros changed the title fix: update nix dependency to 0.29 for FreeBSD compatibility fix: update nix dependency to 0.28 for FreeBSD compatibility Oct 5, 2025
@seuros seuros force-pushed the fix/freebsd-nix-dependency branch from f163389 to 12f1f16 Compare October 6, 2025 04:19
@seuros seuros changed the title fix: update nix dependency to 0.28 for FreeBSD compatibility fix: update nix dependency to 0.30 for FreeBSD compatibility Oct 6, 2025
@seuros seuros force-pushed the fix/freebsd-nix-dependency branch 5 times, most recently from fef0527 to 020413c Compare October 6, 2025 05:43
@seuros seuros marked this pull request as ready for review October 6, 2025 06:07
@seuros seuros force-pushed the fix/freebsd-nix-dependency branch 4 times, most recently from 19064c1 to c93957d Compare October 7, 2025 09:15
@gdavidsson gdavidsson added the dependencies Pull requests that update a dependency file label Oct 17, 2025
@gdavidsson gdavidsson self-requested a review October 17, 2025 17:33
@gdavidsson gdavidsson self-assigned this Oct 17, 2025
@gdavidsson gdavidsson removed their request for review October 17, 2025 17:39
@seuros seuros force-pushed the fix/freebsd-nix-dependency branch 4 times, most recently from 2015986 to a9a95f9 Compare November 25, 2025 13:07
@seuros

seuros commented Nov 25, 2025

Copy link
Copy Markdown
Author

@gdavidsson, do i have to do anything here ? The 1.82 failing build is gone so now the whole suite is passing

wirrareka pushed a commit to wirrareka/pingora that referenced this pull request May 18, 2026
…API hunks only, connect-path changes excluded
- Update nix from 0.27 to 0.30.1
- Add socket feature required for FreeBSD builds
- Remove redundant .into() call (nix 0.28+ returns std::net::Ipv4Addr directly from SockaddrIn::ip())
@seuros seuros force-pushed the fix/freebsd-nix-dependency branch from a9a95f9 to 029d27c Compare June 20, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants