Repository navigation
blitz-dom: fold the retained-memory series into one patch per topic - #162
Merged
Merged
Conversation
BernardoPe
requested review from
LuisDuarte1,
celso,
jonnyparris and
ruifigueira
as code owners
November 17, 2026 18:57
BernardoPe
force-pushed
the
bpereira/fix-main-ci
branch
from
November 17, 2026 19:01
5e8ecbe to
695f14f
Compare
ruifigueira
approved these changes
Nov 17, 2026
BernardoPe
force-pushed
the
bpereira/fix-main-ci
branch
2 times, most recently
from
November 18, 2026 17:10
97a9372 to
77126da
Compare
BernardoPe
force-pushed
the
bpereira/fix-main-ci
branch
3 times, most recently
from
November 19, 2026 13:20
fb76fca to
0ec2f05
Compare
The series grew a patch per review round, so a fix to the patch before it was its own patch, and patches that change the same area landed apart. Fold them: - 0077 keys the id map by atom and keeps shadow ids out of it - 0079 keeps the display:none release, the display it records when shown again, and the scroll offsets a released box keeps - 0080 evicts shaped text, rebuilds a root whose style changes how it breaks, and carries the eviction scan's named steps, which had landed inside the caption-margin alignment patch - 0081 keeps derived child lists on box nodes and reserves their paint buffers - 0082 rebuilds table-cell and list-marker state at paint - 0083 adds the style-only resolve, starts web-font fetches from it, and reshapes only the text a new web font can change - 0084 restyles the whole parent for any relative selector or dir=auto The caption-margin patch keeps only its table.rs change. 103 patches become 94. Every fold rebased without a conflict and the vendor source tree is byte-identical to the series it replaces, so this changes the patch layout and nothing else. The patches main added keep their numbers and stay last in the series, so the numbering runs 0001-0094 then 0104 and 0105, and they still apply on top of the folded series. MODULE.bazel.lock follows. Signed-off-by: bpereira <bpereira@cloudflare.com>
BernardoPe
force-pushed
the
bpereira/fix-main-ci
branch
from
November 20, 2026 12:37
0ec2f05 to
0a89e9d
Compare
BernardoPe
enabled auto-merge (rebase)
November 20, 2026 12:50
ruifigueira
approved these changes
Nov 20, 2026
BernardoPe
added a commit
that referenced
this pull request
Nov 20, 2026
#162 folded the retained-memory series to 0001-0094 but left the two patches main had added at their old numbers, so the directory ran 0001-0094, 0104, 0105. Rename them to 0095 and 0096 so the series is contiguous. The patches still sort in the same order, so the vendor source tree is unchanged. MODULE.bazel.lock follows. Signed-off-by: bpereira <bpereira@cloudflare.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retained-memory series grew a patch per review round: a fix to the patch before it became its own patch, and patches that change the same area landed apart. This folds them, 103 patches into 94:
display:nonerelease, the display it records when shown again, and the scroll offsets a released box keepsdir=autoThe caption-margin patch keeps only its
table.rschange.Nothing but the layout changes
Every fold rebased without a conflict, and the vendor source tree the folded series produces is byte-identical to the tree the series it replaces produces (
24ee3fea5b1078d16c1ea505ecfb33a35565a5fc).Ran:
node scripts/get-patched-vendor-crates.mjs, then compared the resultingblitz-domtree hash withmain'sbazel mod deps --lockfile_mode=errorMODULE.bazel.lockfollows the new series.The two fixes this branch used to carry (the wasm layout stack depth and the Puppeteer client-redirect expectation) are in #174.