Skip to content

chore: add linting to layout-msagl and layout-directed-graph, apply eslint fixes - #3086

Merged
zbynekstara merged 11 commits into
clientIO:masterfrom
zbynekstara:eslint-fix
Oct 30, 2025
Merged

zbynekstara merged 11 commits into
clientIO:masterfrom
zbynekstara:eslint-fix

Conversation

@zbynekstara

@zbynekstara zbynekstara commented Oct 27, 2025 •

Copy link
Copy Markdown
Contributor

Description

Applies linting to packages/joint-layout-directed-graph.

  • Applies ESLint fixes.
  • Additionally updates dist banner to be in line with joint-core dist files.

Applies linting to packages/joint-layout-msagl.

  • Applies ESLint fixes.
  • Additionally updates puppeteer dependency to be in line with the rest of the project (to avoid installation errors).
  • Additionally updates dist banner to be in line with joint-core dist files.

Updates linting on packages/joint-core.

  • Uses a single eslint.config.mjs file.
  • Applies ESLint fixes to files not automatically checked (i.e. packages/joint-core/test, packages/joint-core/types, packages/joint-core/scripts).

@zbynekstara
zbynekstara requested a review from Copilot October 27, 2025 12:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies ESLint fixes across multiple packages (joint-layout-msagl, joint-layout-directed-graph, and joint-core) to enforce consistent code style and quality. The changes include adding ESLint configuration files, updating package dependencies, and fixing linting issues.

  • Standardizes quote styles from double to single quotes across all files
  • Adds missing semicolons and fixes trailing commas
  • Introduces ESLint configuration and linting scripts to previously unchecked packages

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/joint-layout-msagl/src/utils.mts Fixed quote styles and added missing semicolon
packages/joint-layout-msagl/src/types.mts Standardized import quotes to single quotes
packages/joint-layout-msagl/src/index.mts Fixed quote styles and added missing semicolon
packages/joint-layout-msagl/src/enums.mts Standardized import quotes to single quotes
packages/joint-layout-msagl/src/defaults.mts Standardized import quotes to single quotes
packages/joint-layout-msagl/rollup.config.mjs Added banner comment, fixed string formatting, and updated banner text
packages/joint-layout-msagl/package.json Added ESLint dependencies, reorganized scripts, and added lint commands
packages/joint-layout-msagl/eslint.config.mjs Added comprehensive ESLint configuration for the package
packages/joint-layout-directed-graph/test/index.js Fixed reference from g.Rect to joint.g.Rect
packages/joint-layout-directed-graph/rollup.config.mjs Fixed string formatting for date concatenation
packages/joint-layout-directed-graph/package.json Added ESLint dependencies and lint commands
packages/joint-layout-directed-graph/eslint.config.mjs Added ESLint configuration for the package
packages/joint-layout-directed-graph/DirectedGraph.mjs Added missing semicolon
packages/joint-core/types/eslint.config.mjs Removed redundant ignores configuration
packages/joint-core/test/eslint.config.mjs Removed ignores and reorganized configuration structure
packages/joint-core/scripts/parseDocs.js Removed redundant return before process.exit
packages/joint-core/scripts/demos.js Added missing semicolons
packages/joint-core/package.json Updated ESLint-related dependencies to newer versions
packages/joint-core/eslint.config.mjs Restructured configuration with improved organization
eslint.config.mjs Restructured root configuration matching joint-core changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/joint-layout-msagl/rollup.config.mjs
@zbynekstara zbynekstara changed the title Eslint fix chore: eslint fixes Oct 27, 2025
@zbynekstara zbynekstara changed the title chore: eslint fixes chore: add linting to joint-layout-msagl, apply eslint fixes Oct 27, 2025
@zbynekstara zbynekstara changed the title chore: add linting to joint-layout-msagl, apply eslint fixes chore: add linting to layout-msagl and layout-directed-graph, apply eslint fixes Oct 27, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (4)

packages/joint-core/test/eslint.config.mjs:1

  • The import path 'eslint/config' does not exist in ESLint. ESLint does not export a defineConfig function from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without using defineConfig. Remove this import and change line 7 to export default [ instead of export default defineConfig([.
import { defineConfig } from 'eslint/config';

packages/joint-core/types/eslint.config.mjs:1

  • The import path 'eslint/config' does not exist in ESLint. ESLint does not export a defineConfig function from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without using defineConfig. Remove this import and change line 6 to export default [ instead of export default defineConfig([.
import { defineConfig } from 'eslint/config';

packages/joint-core/eslint.config.mjs:1

  • The import path 'eslint/config' does not exist in ESLint. ESLint does not export a defineConfig function from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without using defineConfig. Remove this import and change line 5 to export default [ instead of export default defineConfig([.
import { defineConfig } from 'eslint/config';

eslint.config.mjs:1

  • The import path 'eslint/config' does not exist in ESLint. ESLint does not export a defineConfig function from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without using defineConfig. Remove this import and change line 5 to export default [ instead of export default defineConfig([.
import { defineConfig } from 'eslint/config';

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/joint-layout-msagl/eslint.config.mjs
Comment thread packages/joint-layout-directed-graph/eslint.config.mjs
Comment thread packages/joint-layout-msagl/package.json Outdated
Comment thread packages/joint-layout-directed-graph/package.json Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 41 out of 48 changed files in this pull request and generated 13 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/joint-layout-msagl/eslint.config.mjs
Comment thread packages/joint-layout-msagl/eslint.config.mjs
Comment thread packages/joint-layout-directed-graph/eslint.config.mjs
Comment thread packages/joint-core/eslint.config.mjs
Comment thread packages/joint-core/eslint.config.mjs
Comment thread packages/joint-core/test/ts/index.test.ts
Comment thread packages/joint-core/test/ts/index.test.ts
Comment thread packages/joint-core/test/ts/index.test.ts
Comment thread packages/joint-core/test/ts/index.test.ts
Comment thread packages/joint-core/test/ts/layers.test.ts
@zbynekstara
zbynekstara merged commit bf1842d into clientIO:master Oct 30, 2025
2 checks passed
@zbynekstara
zbynekstara deleted the eslint-fix branch October 30, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants