Repository navigation
chore: add linting to layout-msagl and layout-directed-graph, apply eslint fixes - #3086
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR applies ESLint fixes across multiple packages (joint-layout-msagl, joint-layout-directed-graph, and joint-core) to enforce consistent code style and quality. The changes include adding ESLint configuration files, updating package dependencies, and fixing linting issues.
- Standardizes quote styles from double to single quotes across all files
- Adds missing semicolons and fixes trailing commas
- Introduces ESLint configuration and linting scripts to previously unchecked packages
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/joint-layout-msagl/src/utils.mts | Fixed quote styles and added missing semicolon |
| packages/joint-layout-msagl/src/types.mts | Standardized import quotes to single quotes |
| packages/joint-layout-msagl/src/index.mts | Fixed quote styles and added missing semicolon |
| packages/joint-layout-msagl/src/enums.mts | Standardized import quotes to single quotes |
| packages/joint-layout-msagl/src/defaults.mts | Standardized import quotes to single quotes |
| packages/joint-layout-msagl/rollup.config.mjs | Added banner comment, fixed string formatting, and updated banner text |
| packages/joint-layout-msagl/package.json | Added ESLint dependencies, reorganized scripts, and added lint commands |
| packages/joint-layout-msagl/eslint.config.mjs | Added comprehensive ESLint configuration for the package |
| packages/joint-layout-directed-graph/test/index.js | Fixed reference from g.Rect to joint.g.Rect |
| packages/joint-layout-directed-graph/rollup.config.mjs | Fixed string formatting for date concatenation |
| packages/joint-layout-directed-graph/package.json | Added ESLint dependencies and lint commands |
| packages/joint-layout-directed-graph/eslint.config.mjs | Added ESLint configuration for the package |
| packages/joint-layout-directed-graph/DirectedGraph.mjs | Added missing semicolon |
| packages/joint-core/types/eslint.config.mjs | Removed redundant ignores configuration |
| packages/joint-core/test/eslint.config.mjs | Removed ignores and reorganized configuration structure |
| packages/joint-core/scripts/parseDocs.js | Removed redundant return before process.exit |
| packages/joint-core/scripts/demos.js | Added missing semicolons |
| packages/joint-core/package.json | Updated ESLint-related dependencies to newer versions |
| packages/joint-core/eslint.config.mjs | Restructured configuration with improved organization |
| eslint.config.mjs | Restructured root configuration matching joint-core changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0842532 to
0d13b6f
Compare
e299eca to
a6ad7d5
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (4)
packages/joint-core/test/eslint.config.mjs:1
- The import path 'eslint/config' does not exist in ESLint. ESLint does not export a
defineConfigfunction from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without usingdefineConfig. Remove this import and change line 7 toexport default [instead ofexport default defineConfig([.
import { defineConfig } from 'eslint/config';
packages/joint-core/types/eslint.config.mjs:1
- The import path 'eslint/config' does not exist in ESLint. ESLint does not export a
defineConfigfunction from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without usingdefineConfig. Remove this import and change line 6 toexport default [instead ofexport default defineConfig([.
import { defineConfig } from 'eslint/config';
packages/joint-core/eslint.config.mjs:1
- The import path 'eslint/config' does not exist in ESLint. ESLint does not export a
defineConfigfunction from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without usingdefineConfig. Remove this import and change line 5 toexport default [instead ofexport default defineConfig([.
import { defineConfig } from 'eslint/config';
eslint.config.mjs:1
- The import path 'eslint/config' does not exist in ESLint. ESLint does not export a
defineConfigfunction from this path. The correct approach for ESLint 9.x flat configs is to export an array directly without usingdefineConfig. Remove this import and change line 5 toexport default [instead ofexport default defineConfig([.
import { defineConfig } from 'eslint/config';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7d041b2 to
45aaae9
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 41 out of 48 changed files in this pull request and generated 13 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
45aaae9 to
0e6d9f1
Compare
Description
Applies linting to
packages/joint-layout-directed-graph.Applies linting to
packages/joint-layout-msagl.Updates linting on
packages/joint-core.eslint.config.mjsfile.packages/joint-core/test,packages/joint-core/types,packages/joint-core/scripts).