Repository navigation
fix(env): detect AppleWebKit instead of just Safari - #3067
Merged
Merged
Conversation
zbynekstara
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the browser detection logic to check for AppleWebKit instead of just Safari to properly handle WebKit-based bugs across more browsers. This change addresses a WebKit bug that affects not only Safari but also browsers using WKWebView.
- Renamed
isSafarifunction toisAppleWebKitwith improved detection logic - Updated all references to use the new function name
- Modified comments to reflect the broader scope of affected browsers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/joint-core/src/env/index.mjs | Replaced Safari-specific detection with AppleWebKit detection that excludes Chromium-based browsers |
| packages/joint-core/src/dia/LinkView.mjs | Updated function calls and method names to use the new WebKit detection logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kumilingus
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on top of #2677 (v4.0.4). Instead of checking for Safari (plus iOS), we should check for AppleWebKit minus Chrome.
Motivation and Context
The offending bug (https://bugs.webkit.org/show_bug.cgi?id=268376) also affects browsers using WkWebView, which were previously omitted by the Safari check. The new check identifies: