Skip to content

feat(dia.Cell): add cell attributes merge strategy - #3066

Merged
kumilingus merged 3 commits into
clientIO:masterfrom
kumilingus:cell-merge-strategy
Sep 16, 2025
Merged

kumilingus merged 3 commits into
clientIO:masterfrom
kumilingus:cell-merge-strategy

Conversation

@kumilingus

@kumilingus kumilingus commented Sep 13, 2025 •

Copy link
Copy Markdown
Contributor

Description

This PR adds configurable cell attributes merge strategies to the JointJS library. It introduces two new configuration options that allow developers to customize how cell attributes are merged during initialization and property updates.

  • Adds cellDefaultsMergeStrategy and cellMergeStrategy configuration options
  • Implements configurable merge behavior in cell constructor and prop() method
  • Adds test coverage for the new merge strategy configurations

@kumilingus
kumilingus requested a review from Copilot September 13, 2025 09:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable cell attributes merge strategies to the JointJS library. It introduces two new configuration options that allow developers to customize how cell attributes are merged during initialization and property updates.

  • Adds cellDefaultsMergeStrategy and cellMergeStrategy configuration options
  • Implements configurable merge behavior in cell constructor and prop() method
  • Adds comprehensive test coverage for the new merge strategy configurations

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/joint-core/src/config/index.mjs Adds two new merge strategy configuration options with documentation
packages/joint-core/src/dia/Cell.mjs Implements the configurable merge strategies in cell initialization and prop() method
packages/joint-core/test/jointjs/cell.js Adds test cases to verify the merge strategy configurations work correctly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/joint-core/src/dia/Cell.mjs
Comment thread packages/joint-core/test/jointjs/cell.js Outdated
@kumilingus
kumilingus requested a review from Copilot September 13, 2025 10:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread packages/joint-core/src/dia/Cell.mjs Outdated
@kumilingus
kumilingus marked this pull request as ready for review September 13, 2025 10:49
@kumilingus
kumilingus merged commit 7599ec3 into clientIO:master Sep 16, 2025
3 checks passed
@kumilingus
kumilingus deleted the cell-merge-strategy branch September 16, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants