Repository navigation
feat(dia.Cell): add cell attributes merge strategy - #3066
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable cell attributes merge strategies to the JointJS library. It introduces two new configuration options that allow developers to customize how cell attributes are merged during initialization and property updates.
- Adds
cellDefaultsMergeStrategyandcellMergeStrategyconfiguration options - Implements configurable merge behavior in cell constructor and
prop()method - Adds comprehensive test coverage for the new merge strategy configurations
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/joint-core/src/config/index.mjs | Adds two new merge strategy configuration options with documentation |
| packages/joint-core/src/dia/Cell.mjs | Implements the configurable merge strategies in cell initialization and prop() method |
| packages/joint-core/test/jointjs/cell.js | Adds test cases to verify the merge strategy configurations work correctly |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kumilingus
marked this pull request as ready for review
September 13, 2025 10:49
zbynekstara
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds configurable cell attributes merge strategies to the JointJS library. It introduces two new configuration options that allow developers to customize how cell attributes are merged during initialization and property updates.
cellDefaultsMergeStrategyandcellMergeStrategyconfiguration optionsprop()method