Repository navigation
fix #84 Rename LogRecord::hasContext() to hasContextInfo() (log context no longer displayed) - #87
Merged
Merged
Conversation
…rtyAccessor used it to read the context property, the context was no longer displayed on the log detail page Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression of #84 (PR #86, not released yet).
LogRecord::hasContext()(added by #84) is picked by the Symfony PropertyAccessor to read thecontextproperty (it triesgetContext(),isContext(), thenhasContext()): EasyAdmin then getstrueinstead of the context array, and the "Context" field of the log detail page is empty. Found by the functional tests of #81.LogRecord::hasContext()renamed tohasContextInfo()(as the "Has context info ?" column), used byLogRecordCrudController;contextIsEmpty()(deprecated) points to itLogRecordTest: thecontextproperty is readable by the PropertyAccessor (returnstruewithout the fix)Latestentry of LogRecord::contextIsEmpty() returns true when the context is not empty #84 updatedNo deprecation needed:
hasContext()was never released (v3.0.2 does not contain #84).Requirements
Breaking changes
None (unreleased method).
🤖 Generated with Claude Code