Repository navigation
#200 - UserCrudController: reserve the generateToken action to ROLE_ADMIN - #201
Open
njoubert-cleverage wants to merge 1 commit into
Open
njoubert-cleverage wants to merge 1 commit into
njoubert-cleverage wants to merge 1 commit into
Conversation
…DMIN, 404 for an unknown user Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #200.
generateToken()gets#[IsGranted('ROLE_ADMIN')], the permission of the users (setEntityPermission(), applied by EasyAdmin to its built-in actions only), and answers404when the user is not found. AROLE_USERnow gets a403instead of a500(setToken()on null).The CSRF protection of this action is #115 / #116 (v4.0): #116 will need a trivial rebase on this change.
Requirements
Breaking changes
None.
🤖 Generated with Claude Code