Skip to content

fix #97 Make process_execution.context nullable, as in the mapping - #101

Merged
njoubert-cleverage merged 1 commit into
mainfrom
97-context
Oct 5, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
97-context

Conversation

@njoubert-cleverage

@njoubert-cleverage njoubert-cleverage commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes #97 (third column, found after #98 was merged).

process_execution.context is created as JSON NOT NULL by Version20241007152613, while ProcessExecution::$context is mapped as nullable: true. As Version20261005120000 (added by #98) has never been released, it is completed instead of adding a new migration:

MySQL / MariaDB PostgreSQL
up (added) ALTER TABLE process_execution MODIFY context JSON DEFAULT NULL ALTER TABLE process_execution ALTER context DROP NOT NULL
down (added) ALTER TABLE process_execution MODIFY context JSON NOT NULL ALTER TABLE process_execution ALTER context SET NOT NULL

The CHANGELOG entry of #97 describes the whole migration, as a single change.

No failure today: ProcessExecution always sets at least [], this only aligns the schema on the mapping.

Checked:

  • process-bundle-demo, MySQL 9.1: down / up of Version20261005120000 (3 statements): log_record.process_execution_id NOT NULL and process_execution.context nullable, both no longer reported by doctrine:schema:update --dump-sql; a process still runs
  • PostgreSQL 16 (throwaway container): fresh database, migrations OK, both columns as in the mapping, schema diff: only the cosmetic (DC2Type:...) comments; down / up OK
  • bundle (Symfony 8.1, PHP 8.5): 257 tests OK. PHPStan, PHP-CS-Fixer, Rector OK

Note: a database that already executed Version20261005120000 (e.g. a development environment on main) does not get the context change: run doctrine:migrations:execute --down then --up on it.

Requirements

  • Documentation updates
    • Reference
    • Changelog
  • Unit tests

Breaking changes

None.

🤖 Generated with Claude Code

@njoubert-cleverage njoubert-cleverage added the bug Something isn't working label Oct 5, 2026
process_execution.context was created as NOT NULL by Version20241007152613 while the mapping declares it nullable.
Handled in Version20261005120000 (added by #98, never released).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage merged commit 29e3dff into main Oct 5, 2026
18 checks passed
@njoubert-cleverage
njoubert-cleverage deleted the 97-context branch October 5, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mapping and schema created by the migrations differ: process_schedule.input, log_record.process_execution_id, process_execution.context

1 participant