Repository navigation
fix #97 Make process_execution.context nullable, as in the mapping - #101
Merged
Merged
Conversation
process_execution.context was created as NOT NULL by Version20241007152613 while the mapping declares it nullable. Handled in Version20261005120000 (added by #98, never released). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
njoubert-cleverage
force-pushed
the
97-context
branch
from
October 5, 2026 13:26
0edce82 to
e41c135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #97 (third column, found after #98 was merged).
process_execution.contextis created asJSON NOT NULLbyVersion20241007152613, whileProcessExecution::$contextis mapped asnullable: true. AsVersion20261005120000(added by #98) has never been released, it is completed instead of adding a new migration:up(added)ALTER TABLE process_execution MODIFY context JSON DEFAULT NULLALTER TABLE process_execution ALTER context DROP NOT NULLdown(added)ALTER TABLE process_execution MODIFY context JSON NOT NULLALTER TABLE process_execution ALTER context SET NOT NULLThe CHANGELOG entry of #97 describes the whole migration, as a single change.
No failure today:
ProcessExecutionalways sets at least[], this only aligns the schema on the mapping.Checked:
down/upofVersion20261005120000(3 statements):log_record.process_execution_idNOT NULLandprocess_execution.contextnullable, both no longer reported bydoctrine:schema:update --dump-sql; a process still runs(DC2Type:...)comments;down/upOKNote: a database that already executed
Version20261005120000(e.g. a development environment onmain) does not get thecontextchange: rundoctrine:migrations:execute --downthen--upon it.Requirements
Breaking changes
None.
🤖 Generated with Claude Code