Repository navigation
#239 - Fix PropertyGetterTask: a scalar input bypassed the error_strategy - #246
Merged
Merged
Conversation
…t the `TypeError` of the property accessor on a scalar input is set on the state (with the `property` error context) and handled according to the task `error_strategy` instead of escaping it. Update documentation, add tests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #239.
PropertyGetterTaskonly caught\Exception: on a scalar input, theTypeErrorthrown by the PropertyAccessor escapedexecute(), so thepropertyerror context was not set and the taskerror_strategywas bypassed.\Throwableinstead of\Exception, asPropertySetterTaskdoes since Edge cases looping forever or failing with a TypeError: FileSplitterTask, PropertySetterTask, SlugifyTransformer, InputFolderBrowserTask, XmlFile #232;docs/reference/tasks/property_getter_task.md(same wording as the PropertySetterTask page);PropertyGetterTaskTest::testScalarInputSetsExceptionWithErrorContext(fails onmainwith the uncaughtTypeError).PHPUnit (802 tests), PHPStan, PHP-CS-Fixer and Rector pass, and the changed files are valid PHP 8.2.
Requirements
Breaking changes
None: this case currently ends with an uncaught
TypeError; it now follows the documented error handling.🤖 Generated with Claude Code