Skip to content

Add Volunteer nav link to employment platform - #202

Open
mikewolfd wants to merge 1 commit into
mainfrom
add-platform-nav-link
Open

Add Volunteer nav link to employment platform#202
mikewolfd wants to merge 1 commit into
mainfrom
add-platform-nav-link

Conversation

@mikewolfd

Copy link
Copy Markdown
Member

What

Adds a Volunteer item to the primary navigation, linking to the Civic Tech DC employment platform at https://platform.civictechdc.org.

Why

The employment-platform is a separate Next.js + Supabase app (deployed to Vercel) that lets volunteers browse projects and find where to contribute. Rather than fold a database-backed app into this static Jekyll/GitHub Pages site, the two stay independently deployed and the only contract between them is the URL.

Changes

  • One new usa-nav__primary-item in _includes/core/header.html, placed after Projects.
  • It's an absolute outbound link, so it intentionally skips the aria-current page-matching logic the internal nav items use.

Notes / out of scope

  • Requires the platform team to point a CNAME for platform.civictechdc.org at Vercel and add the domain to the Vercel project. The link 404s until that DNS is live — merge once the platform is deployed (or accept a temporary dead link).
  • No asset regeneration, submodule, or hosting change. npm run lint passes.

🤖 Generated with Claude Code

Links the primary nav to the Civic Tech DC employment platform
(a separate Next.js/Supabase app deployed to platform.civictechdc.org).
The two sites stay independently deployed; the only contract is the URL.

Placed after Projects as an outbound absolute link, so it skips the
internal aria-current logic the other nav items use.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a 'Volunteer' navigation link to the header pointing to an external platform. The feedback suggests avoiding hardcoding this external URL directly in the template to facilitate local or staging environment testing, recommending instead to define it in _config.yml with a fallback.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +28 to +32
<li class="usa-nav__primary-item">
<a class="usa-nav__link" href="https://platform.civictechdc.org">
<span>Volunteer</span>
</a>
</li>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Hardcoding the external platform URL directly in the template makes it difficult to point to local or staging environments (such as http://localhost:3000 or a Vercel preview URL) during development and testing.

Consider defining the platform URL in _config.yml (e.g., platform_url: https://platform.civictechdc.org) and referencing it here with a fallback to the production URL.

        <li class="usa-nav__primary-item">
          <a class="usa-nav__link" href="{{ site.platform_url | default: 'https://platform.civictechdc.org' }}">
            <span>Volunteer</span>
          </a>
        </li>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant