Skip to content

[windows-smoke] Breadcrumb: F7 version handling broken + fix pointers + reference notesΒ #1

Description

@chaoz23

Breadcrumb from the Mac-side session for the on-box Windows testing instance. πŸ‘‹

Pull latest first

git pull on windows-smoke β€” latest is d62f9c4. It adds F7 + reference notes to SMOKE_TEST_FINDINGS.md. If you cloned earlier you don't have these yet.

F7 β€” version handling is broken on Windows (🟠 Major)

version/version.go GetCurrentVersion() shells out to the macOS defaults command to read CFBundleVersion from Info.plist. defaults doesn't exist on Windows β†’ it errors β†’ returns ""/"dev". So the About page shows "dev" and the update-check sends an empty version.

Also: installer.iss / winget / versioninfo.json all hardcode 4.2.2, but the fork base is v4.4.0-alpha + 9 (git describe = v4.4.0-alpha-9-gd4d62f8). 4.2.2 is a stale stable that predates the Rules UI.

Suggested fix: add var version string in version.go, return it before the Info.plist fallback (keeps macOS dev behavior intact), and set it via -ldflags "-X finicky/version.version=$(git describe --tags)" in the build. Align the manifests to ~4.4.0-alpha (provisional β€” the final version scheme is johnste's call).
⚠️ version.go is shared code β€” don't diverge it in a _windows.go file. Either coordinate, or leave F7 to the Mac session (it can verify the macOS build doesn't break).

Open-bug classification (from the architecture)

  • F3 (empty browser dropdown) = Windows-specific. macOS detect.go (mdfind/plist) populates it fine; detect_windows.go's registry scan is returning empty. Check the diagnostic logs: Browser registry scan root=HKCU found=N, root=HKLM found=N, Installed browsers detected count=N.
  • F4 (rule-editor focus) = shared Svelte code (Rules.svelte selfSaved guard). Verify it actually holds focus under WebView2.

Reference build

Correct macOS reference = v4.4.0-alpha (has the Rules UI). NOT v4.2.2 ("Latest", but predates the Rules editor).

Full context: WINDOWS_TESTING_HANDOFF.md + SMOKE_TEST_FINDINGS.md on windows-smoke.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions