Attempt to fix set static panel - #2
Open
AdrieanKhisbe wants to merge 2 commits into
Open
Conversation
2 similar comments
Author
|
gentle up :) |
Author
|
👋 @ceejbot some gentle reminder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome library.
I tried to use the setStaticPanel, but I got some 422 Unprocessable Entity.
I tweaked around, and I managed to make it work by modifying a condition.
This might have been caused by a changed of api, that would return an empty panels rather than undefined.
I'm new to nanoleaf so it's possible that I have misunderstood something. :)
I took the opportunity to add node 10 to the tests