Possibility to use an override config file - #320
Merged
Conversation
🦋 Changeset detectedLatest commit: 9a602ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report for ./apps/cli
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
Using honeypot branch to test, I get the following error but it's not clear what is the problem: |
tuler
force-pushed
the
feature/use-docker-machine
branch
from
July 22, 2025 20:39
11a7966 to
a2f1448
Compare
Base automatically changed from
feature/use-docker-machine
to
prerelease/v2-alpha
July 22, 2025 20:39
tuler
force-pushed
the
feature/merge-multiple-config
branch
from
July 22, 2025 20:40
26a32ad to
9a602ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the use of multiple config files for build, with an override strategy.
This enables something like:
Where
cartesi.tomlcontains common configuration, andcartesi.mainnet.tomlonly contains values that should complement or override values incartesi.toml. This helps to reduce code duplication, improving maintenance, like in this commit.This PR also removes 3 properties from the config that I think could lead to confusion:
interactive,storeandfinalHash