Skip to content

Make blue build with MSVCv145 by default on windows#7

Open
ccptoebeans wants to merge 3 commits into
carbonengine:mainfrom
ccptoebeans:v145
Open

Make blue build with MSVCv145 by default on windows#7
ccptoebeans wants to merge 3 commits into
carbonengine:mainfrom
ccptoebeans:v145

Conversation

@ccptoebeans

@ccptoebeans ccptoebeans commented Jul 24, 2026

Copy link
Copy Markdown
Member
  • CMake Presets changed to use v145 toolchain file + v145 vcpkg triplets
  • Team City configuration changed to use v145 by default
  • Minor code changes to enable new compiler use
    • NULL or 0 can no longer be returned from PyObject* type functions
    • #include <locale.h> must be explicitly included, old windows SDK was exposing local through some other include
  • rely on carbon-core v3.0.1 which contains fixed public header files compilable with v145 (this broke initially after the inital v145 change as part of Tracy changes. )
  • rely on carbon-pdmprotowrapper v3.0.0 which does not exist yet. This has been tested locally using an overlay port. A forked vcpkg-registry will be created with this version contained in it. It does not mean that v3.0.0 is the defacto version number choice for carbon-pdmprotowrapper, as we will upgrade the port seperately when we are ready to merge the pdm-proto-wrapper changes
  • We are no longer forced to pin the protobuf version everywhere in our build tree 🎉 - Override removed

Comment thread src/YamlReader.cpp
#ifndef _WIN32
#include <locale>
#include <codecvt>
#else

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move the above #include <locale> statement in front of the #ifndef instead of introducing the #else branch?

Comment thread CMakePresets.json
"VCPKG_TARGET_TRIPLET": "x64-windows-internal",
"VCPKG_HOST_TRIPLET": "x64-windows-internal"
"VCPKG_TARGET_TRIPLET": "x64-windows-145-internal",
"VCPKG_HOST_TRIPLET": "x64-windows-145-internal"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this rename the preset to include 145 as well? And is truly really no longer buildable with v141?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants