Make blue build with MSVCv145 by default on windows#7
Open
ccptoebeans wants to merge 3 commits into
Open
Conversation
CCP-Aporia
reviewed
Jul 24, 2026
| #ifndef _WIN32 | ||
| #include <locale> | ||
| #include <codecvt> | ||
| #else |
Member
There was a problem hiding this comment.
Why not move the above #include <locale> statement in front of the #ifndef instead of introducing the #else branch?
| "VCPKG_TARGET_TRIPLET": "x64-windows-internal", | ||
| "VCPKG_HOST_TRIPLET": "x64-windows-internal" | ||
| "VCPKG_TARGET_TRIPLET": "x64-windows-145-internal", | ||
| "VCPKG_HOST_TRIPLET": "x64-windows-145-internal" |
Member
There was a problem hiding this comment.
Shouldn't this rename the preset to include 145 as well? And is truly really no longer buildable with v141?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NULLor0can no longer be returned fromPyObject*type functions#include <locale.h>must be explicitly included, old windows SDK was exposing local through some other includecarbon-corev3.0.1which contains fixed public header files compilable with v145 (this broke initially after the inital v145 change as part of Tracy changes. )carbon-pdmprotowrapperv3.0.0which does not exist yet. This has been tested locally using an overlay port. A forked vcpkg-registry will be created with this version contained in it. It does not mean that v3.0.0 is the defacto version number choice for carbon-pdmprotowrapper, as we will upgrade the port seperately when we are ready to merge the pdm-proto-wrapper changes