Repository navigation
Add external HSM signing flow - #631
Merged
Merged
Conversation
rem1niscence
approved these changes
Oct 12, 2026
| if prepared == nil { | ||
| return nil, nil, signingProfile{}, fmt.Errorf("prepared send is nil") | ||
| } | ||
| if prepared.Version != PreparedSendVersion { |
Collaborator
There was a problem hiding this comment.
PreparedSendVersion is a string and is a full equality check, wouldn't this locks of out of version upgrades that may have backwards compatibility?
Collaborator
Author
There was a problem hiding this comment.
It’s the external signer version, not the Canopy node/release version - it shouldn't affect version upgrades. Canopy software can release many versions while continuing to use canopy-hsm-v1
pablocampogo
approved these changes
Oct 12, 2026
rem1niscence
approved these changes
Oct 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a prepare/finalize flow so external HSMs can sign native sends without implementing Canopy protobuf encoding. Supports Ed25519 and secp256k1, including raw and DER ECDSA signatures.