Repository navigation
fix: no liquidity sync failing for liveness fallback - #629
Merged
Merged
Conversation
rem1niscence
approved these changes
Oct 12, 2026
andrewnguyen22
approved these changes
Oct 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canopy — Pin DEX liveness-fallback decision to the committed certificate
Problem
HandleDexBatchreadLivenessFallbackoffs.cache.rootDexBatchafter the cache swap. On the sync/replay path that cache is seeded from the next committed certificate, so a replaying node fired the fallback one block early and diverged from canonical state.Fix
Capture the fallback decision from the quorum-committed certificate batch before the cache swap, and use the cache only as the batch data source. Live and replay paths now reach the same decision.
Files
fsm/dex.goRisk: consensus-affecting; no behavior change on the live path, only fixes replay determinism.