Convert dependency-table to TypeScript; remove dead code (#5)#17
Merged
Conversation
Unreachable branch, unused destructures/params, unnecessary regex escapes predate the TS conversion (markdown-magic-plugins#5). Lint now runs over index.ts with no exclusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave-A TypeScript conversion (engines pilot pattern) in two commits:
findPkg(srcPath)semantic preserved exactly. Documented exception to the byte-for-byte contract: the deadnpmPkgUrlconst (unused on main, verified) was dropped in this commit rather than the cleanup commit — flagged by review; accepted as-disclosed rather than rewriting history._contentrename — each removal individually adjudicated as provably inert by review; the eslint exclusion for this file is deleted and the whole file now lints clean.Validation: typecheck + lint (no exclusions) + prettier clean · 13/13 tests · workspace green · tarball gate incl. consumer-typecheck · node example.ts exit 0 · docs idempotent · code-reviewed (APPROVE)