Convert install-command to TypeScript#16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave-A TypeScript conversion (engines pilot pattern): exhaustive
Client = 'npm' | 'yarn' | 'pnpm' | 'bun'union, typed installMappings table (values verified byte-identical to main), dist packaging + prepack, changeset minor.Logic byte-for-byte vs main — all recently-shipped behavior (bun/pnpm detection, global-flag handling) preserved and covered by its 5 tests. One TS-narrowing accommodation adjudicated referentially identical (
Object.keys(pkgPeers)— const alias of the same object). Reviewer P2 recorded (redundantas unknown as stringcast — cosmetic).Validation: typecheck + lint + prettier clean · workspace tests green · tarball gate incl. consumer-typecheck (compile AND runtime consumer run) · node example.ts exit 0 · docs idempotent (md5 ×2) · code-reviewed (APPROVE)