Explorer refresh after OPFS add, unique counts shown as estimates - #68
Merged
Merged
Conversation
…how unique counts as estimates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the browser pass. Adding a browser-storage connection made it active but the explorer kept the previous catalog until the next query; the add path now refetches the schema like a switch does, and a failed fetch does not fail the add (slice test). The Stats cards took SUMMARIZE's approx_unique, a HyperLogLog estimate, as exact, giving things like Unique 41 on 40 rows and Cardinality 120%; the count is now capped at the number of non-null rows, cardinality at 100%, and both are shown with an approximately sign.