Repository navigation
Saved connections survive a reload - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On boot the profile loaded its saved connections, then the engine's initialize replaced the whole list with WASM and the ENV connection, so every saved connection vanished on reload (re-adding one then wrote a second row with the same name). Both steps now merge by id in whichever order they run; loadProfile keeps the built-in connections and replaces only the profile's own rows, so switching profiles does not carry them over. Unit tests for the merge and for initialize keeping what the profile loaded. New Playwright test adds a browser-storage connection, reloads and checks it is listed exactly once; it fails on the previous build. Not in this PR: the saved current connection is still not restored on reload.