fix: six small fixes from the work log - #208
Merged
Merged
Conversation
…kHouse user names, login connector label, /settings alias, telemetry missing tables)
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six small fixes from WORK_LOG §0.1 item 3 (including 4.19 and 4.20). No schema or dependency change.
ch_userwas stored and returned by the API but missing on the page, in the CSV export and in SIEM events. Now a "ClickHouse user" column and detail row, ach_userCSV column, andch_useron forwarded events (stdout, file, webhook). Same rule as storage: only when it differs from the actor.@or:failed, and the delete self-guard compared the escaped name.?section=, so old links open the License page instead of home (4.20).Docs: audit-log, monitoring (SIEM event) and cant-login pages updated.
Checked
make vet testpasses;bun run check0 errors;bun run test103 passed (newisMissingTableErrortests); site builds. Two existing tests that asserted the old 200 on a foreign history delete now expect not found.