Skip to content

fix(sqlserver): support verify-full TLS mode - #443

Open
tsiakoulias wants to merge 1 commit into
bytebase:mainfrom
tsiakoulias:fix/sqlserver-verify-full-support
Open

tsiakoulias wants to merge 1 commit into
bytebase:mainfrom
tsiakoulias:fix/sqlserver-verify-full-support

Conversation

@tsiakoulias

Copy link
Copy Markdown

Summary

Add sslmode=verify-full support for SQL Server.

  • Enable TLS with certificate and hostname verification.
  • Accept verify-full in TOML configuration.
  • Keep the current default and other TLS modes.
  • Update the configuration documentation.

Tests

Add two unit tests:

  • Check that verify-full enables encryption and certificate verification.
  • Check that TOML accepts verify-full and includes it in the DSN.

Enable certificate and hostname verification when sslmode=verify-full is explicit. Accept the mode in TOML, document Node trust configuration, and add focused parser and configuration tests. Preserve existing defaults and parsing behavior.
Copilot AI balanced review requested due to automatic review settings September 29, 2026 01:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tianzhou

Copy link
Copy Markdown
Member

Please open an issue first

@tsiakoulias

Copy link
Copy Markdown
Author

Thanks. I opened #446 to describe the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants