Skip to content

ci(nixos): retire the preview label from the testable PR build #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrosseel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(nixos): retire the preview label from the testable PR build #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions .github/workflows/nixos-pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ name: Build PiFinder NixOS (testable PRs)
# `pull_request_target` runs in the BASE repo's trusted context, so the job has
# the real ATTIC_TOKEN and a read-write GITHUB_TOKEN even for fork PRs. The
# contributor's code is checked out explicitly (head SHA) and built. This is
# only reached after a maintainer applies the `testable` (or `preview`) label —
# that label is the security boundary: it runs contributor code with the cache
# push token, so review the diff before labeling, and re-review on each new push
# to a labeled PR.
# only reached after a maintainer applies the `testable` label — that label is
# the security boundary: it runs contributor code with the cache push token, so
# review the diff before labeling, and re-review on each new push to a labeled
# PR.
#
# Build strategy: the free GitHub-hosted ubuntu-24.04-arm runner builds first.
# Its cores are faster than the Pi5, and the Attic cache (cache.pifinder.eu) is
Expand All @@ -33,9 +33,7 @@ permissions:
jobs:
# Primary: free GitHub-hosted arm64 runner (native aarch64, no QEMU).
build-hosted:
if: |
contains(github.event.pull_request.labels.*.name, 'preview') ||
contains(github.event.pull_request.labels.*.name, 'testable')
if: contains(github.event.pull_request.labels.*.name, 'testable')
runs-on: ubuntu-24.04-arm
# Generous: only a kernel/source change compiles from scratch (~1 h on this
# 4-core runner); everything else substitutes from Attic in minutes.
Expand All @@ -52,8 +50,8 @@ jobs:
persist-credentials: false
# Fork PRs: pull_request_target checkout of the head requires opt-in
# since actions/checkout began refusing it. The head SHA is pinned
# explicitly and only reached after the `testable`/`preview` label,
# which is the review gate for running contributor code.
# explicitly and only reached after the `testable` label, which is the
# review gate for running contributor code.
allow-unsafe-pr-checkout: true

- uses: DeterminateSystems/nix-installer-action@main
Expand Down Expand Up @@ -106,8 +104,7 @@ jobs:
needs: build-hosted
if: |
always() &&
(contains(github.event.pull_request.labels.*.name, 'preview') ||
contains(github.event.pull_request.labels.*.name, 'testable')) &&
contains(github.event.pull_request.labels.*.name, 'testable') &&
needs.build-hosted.result == 'failure'
runs-on: [self-hosted, aarch64]
timeout-minutes: 240
Expand All @@ -121,8 +118,8 @@ jobs:
persist-credentials: false
# Fork PRs: pull_request_target checkout of the head requires opt-in
# since actions/checkout began refusing it. The head SHA is pinned
# explicitly and only reached after the `testable`/`preview` label,
# which is the review gate for running contributor code.
# explicitly and only reached after the `testable` label, which is the
# review gate for running contributor code.
allow-unsafe-pr-checkout: true

- name: Ensure nix is on PATH (self-hosted runner)
Expand Down
Loading