Repository navigation
fix: prevent exception when updating a bottle's dependecy list view - #4045
Merged
Merged
Conversation
Member
|
Hi, can u re-make this PR on top of main, please? Sorry for the trouble. |
When calling `DetailsDependenciesView.update()`, addition of new dependency rows were scheduled by calling `GLib.idle_add(new_dependency, dep, plain=True)`, which (AFAIU) was wrong for the following reasons: * `GLib.idle_add()` doesn't support keyword arguments other than "priority" (as an alias for `GLib.idle_add(priority, func, *args)`). This ended up raising "unknown keyword argument" exceptions. * When a `DependencyEntryRow`, is created with `plain=True` then the dependency argument must be a string, not a tuple.
ju1ius
force-pushed
the
ju1ius/fix-idle-add
branch
from
October 14, 2025 18:13
115903e to
f4105bb
Compare
|
Cheers @ju1ius for providing the fix to my issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When calling
DetailsDependenciesView.update(), additions of newDependencyEntryRowinstances were scheduled by callingGLib.idle_add(new_dependency, dep, plain=True).However,
GLib.idle_adddoesn't support keyword arguments other than "priority" (which is an alias forGLib.idle_add(priority, func, *args)). This ended up raising the following exception:Moreover, when a
DependencyEntryRow, is created withplain=Truethen the dependency argument must be astr, not atuple, which was not the case here.Fixes #3983, #3992, #3997, #4006, #4018, #4019, #4037, #4041, #4044.
Type of change
How Has This Been Tested?
By building an runnig the flatpak locally, creating a new bottle, adding and removing some dependencies, while verifying that no relevant exceptions were logged on stdout/err.