test: use compile() instead of ast.parse() to catch semantic errors - #169
Merged
Conversation
ast.parse only validates syntax grammar — it allows 'return' at module level in the AST. compile() catches semantic errors like 'return outside function' that ast.parse misses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ast.parse()only validates Python grammar — it allowsreturnat module level in the AST.compile()catches semantic errors likereturn outside functionthatast.parse()silently accepts.This means the previous test (
test_module_parses) never actually caught the indentation bug inanonymise.py. Switching tocompile()fixes that.Verification
Before this fix,
test_module_compiles[modules/anonymise.py]fails with:This correctly blocks merging until #166 restores the indentation.